From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAXFg-0003EW-3q for qemu-devel@nongnu.org; Mon, 03 Feb 2014 23:04:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAXFS-0006eq-5T for qemu-devel@nongnu.org; Mon, 03 Feb 2014 23:04:48 -0500 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:43460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAXFR-0006dp-CC for qemu-devel@nongnu.org; Mon, 03 Feb 2014 23:04:34 -0500 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 4 Feb 2014 14:04:26 +1000 From: Alexey Kardashevskiy Date: Tue, 4 Feb 2014 15:04:19 +1100 Message-Id: <1391486659-6584-5-git-send-email-aik@ozlabs.ru> In-Reply-To: <1391486659-6584-1-git-send-email-aik@ozlabs.ru> References: <1391486659-6584-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [PATCH v3 4/4] spapr: print more detailed error message on failed load_elf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, Alexander Graf This makes use of new error codes which load_elf() can return and prints more informative error message. Signed-off-by: Alexey Kardashevskiy --- hw/ppc/spapr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 851ce4b..c9dfc6c 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1306,15 +1306,15 @@ static void ppc_spapr_init(QEMUMachineInitArgs *args) kernel_size = load_elf(kernel_filename, translate_kernel_address, NULL, NULL, &lowaddr, NULL, 1, ELF_MACHINE, 0); - if (kernel_size < 0) { + if (kernel_size == ELF_LOAD_WRONG_ENDIAN) { kernel_size = load_elf(kernel_filename, translate_kernel_address, NULL, NULL, &lowaddr, NULL, 0, ELF_MACHINE, 0); kernel_le = kernel_size > 0; } if (kernel_size < 0) { - fprintf(stderr, "qemu: could not load kernel '%s'\n", - kernel_filename); + fprintf(stderr, "qemu: error loading %s: %s\n", + kernel_filename, load_elf_strerror(kernel_size)); exit(1); } -- 1.8.4.rc4