qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, anthony@codemonkey.ws,
	Orit Wasserman <owasserm@redhat.com>
Subject: [Qemu-devel] [PATCH 6/8] XBZRLE cache size should not be larger than guest memory size
Date: Tue,  4 Feb 2014 16:55:32 +0100	[thread overview]
Message-ID: <1391529334-30526-7-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1391529334-30526-1-git-send-email-quintela@redhat.com>

From: Orit Wasserman <owasserm@redhat.com>

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 migration.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/migration.c b/migration.c
index 46a7305..25add6f 100644
--- a/migration.c
+++ b/migration.c
@@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error **errp)
         return;
     }

+    /* Cache should not be larger than guest ram size */
+    if (value > ram_bytes_total()) {
+        error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size",
+                  "exceeds guest ram size ");
+        return;
+    }
+
     new_size = xbzrle_cache_resize(value);
     if (new_size < 0) {
         error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size",
-- 
1.8.5.3

  parent reply	other threads:[~2014-02-04 18:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04 15:55 [Qemu-devel] [PULL v2 0/8] migration queue Juan Quintela
2014-02-04 15:55 ` [Qemu-devel] [PATCH 1/8] vmstate: Make VMSTATE_STRUCT_POINTER take type, not ptr-to-type Juan Quintela
2014-02-04 15:55 ` [Qemu-devel] [PATCH 2/8] exec: fix ram_list dirty map optimization Juan Quintela
2014-02-04 15:55 ` [Qemu-devel] [PATCH 3/8] Set xbzrle buffers to NULL after freeing them to avoid double free errors Juan Quintela
2014-02-04 15:55 ` [Qemu-devel] [PATCH 4/8] Add check for cache size smaller than page size Juan Quintela
2014-02-04 15:55 ` [Qemu-devel] [PATCH 5/8] migration:fix free XBZRLE decoded_buf wrong Juan Quintela
2014-02-04 15:55 ` Juan Quintela [this message]
2014-02-04 15:55 ` [Qemu-devel] [PATCH 7/8] Don't abort on out of memory when creating page cache Juan Quintela
2014-02-04 15:55 ` [Qemu-devel] [PATCH 8/8] Don't abort on memory allocation error Juan Quintela
2014-02-08 13:32 ` [Qemu-devel] [PULL v2 0/8] migration queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391529334-30526-7-git-send-email-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=owasserm@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).