From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAlDN-0003H0-6B for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:59:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAlDD-00069Z-St for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:59:21 -0500 Received: from ssl.serverraum.org ([88.198.40.39]:46369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAlDD-00069S-Mn for qemu-devel@nongnu.org; Tue, 04 Feb 2014 13:59:11 -0500 From: Michael Walle Date: Tue, 4 Feb 2014 19:58:27 +0100 Message-Id: <1391540314-16141-6-git-send-email-michael@walle.cc> In-Reply-To: <1391540314-16141-1-git-send-email-michael@walle.cc> References: <1391540314-16141-1-git-send-email-michael@walle.cc> Subject: [Qemu-devel] [PULL v5 05/12] milkymist-vgafb: swap pixel data in source buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Michael Walle , Anthony Liguori , Paolo Bonzini In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was eliminated. But we are reading from the target buffer a 16-bit value, which is in big-endian format. Therefore, use lduw_be_p() to read the value. Cc: Paolo Bonzini Signed-off-by: Michael Walle --- hw/display/milkymist-vgafb_template.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/milkymist-vgafb_template.h b/hw/display/milkymist-vgafb_template.h index e0036e1..4883780 100644 --- a/hw/display/milkymist-vgafb_template.h +++ b/hw/display/milkymist-vgafb_template.h @@ -61,7 +61,7 @@ static void glue(draw_line_, BITS)(void *opaque, uint8_t *d, const uint8_t *s, uint8_t r, g, b; while (width--) { - memcpy(&rgb565, s, sizeof(rgb565)); + rgb565 = lduw_be_p(s); r = ((rgb565 >> 11) & 0x1f) << 3; g = ((rgb565 >> 5) & 0x3f) << 2; b = ((rgb565 >> 0) & 0x1f) << 3; -- 1.7.10.4