From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Sander Eikelenboom <linux@eikelenboom.it>,
Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen
Date: Tue, 4 Feb 2014 23:32:08 +0200 [thread overview]
Message-ID: <1391549456-465-1-git-send-email-mst@redhat.com> (raw)
xenfv has no fwcfg and so does not load acpi from QEMU.
as such new acpi features don't work.
Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
Sander, could you pleas econfirm this works for you?
Also, Xen really should switch to fw cfg some day ...
hw/i386/pc_piix.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index a327d71..1acd2b2 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -793,6 +793,17 @@ static QEMUMachine xenfv_machine = {
.max_cpus = HVM_MAX_VCPUS,
.default_machine_opts = "accel=xen",
.hot_add_cpu = pc_hot_add_cpu,
+ .compat_props = (GlobalProperty[]) {
+ /* xenfv has no fwcfg and so does not load acpi from QEMU.
+ * as such new acpi features don't work.
+ */
+ {
+ .driver = "PIIX4_PM",
+ .property = "acpi-pci-hotplug-with-bridge-support",
+ .value = "off",
+ },
+ { /* end of list */ }
+ },
};
#endif
--
MST
next reply other threads:[~2014-02-04 21:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 21:32 Michael S. Tsirkin [this message]
2014-02-04 21:55 ` [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen Paolo Bonzini
2014-02-04 22:28 ` Sander Eikelenboom
2014-02-05 16:35 ` Stefano Stabellini
2014-02-05 16:45 ` Sander Eikelenboom
2014-02-05 16:50 ` Stefano Stabellini
2014-02-05 16:41 ` Stefano Stabellini
2014-02-05 16:47 ` Paolo Bonzini
2014-02-05 16:54 ` Stefano Stabellini
2014-02-05 17:04 ` Paolo Bonzini
2014-02-05 17:53 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391549456-465-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@amazon.com \
--cc=linux@eikelenboom.it \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).