From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAnWX-0001Wt-SB for qemu-devel@nongnu.org; Tue, 04 Feb 2014 16:27:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WAnWT-0000lN-6g for qemu-devel@nongnu.org; Tue, 04 Feb 2014 16:27:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WAnWS-0000lH-V6 for qemu-devel@nongnu.org; Tue, 04 Feb 2014 16:27:13 -0500 Date: Tue, 4 Feb 2014 23:32:08 +0200 From: "Michael S. Tsirkin" Message-ID: <1391549456-465-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [Qemu-devel] [PATCH] pc_piix: enable legacy hotplug for Xen List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Sander Eikelenboom , Anthony Liguori xenfv has no fwcfg and so does not load acpi from QEMU. as such new acpi features don't work. Reported-by: Sander Eikelenboom Signed-off-by: Michael S. Tsirkin --- Sander, could you pleas econfirm this works for you? Also, Xen really should switch to fw cfg some day ... hw/i386/pc_piix.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index a327d71..1acd2b2 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -793,6 +793,17 @@ static QEMUMachine xenfv_machine = { .max_cpus = HVM_MAX_VCPUS, .default_machine_opts = "accel=xen", .hot_add_cpu = pc_hot_add_cpu, + .compat_props = (GlobalProperty[]) { + /* xenfv has no fwcfg and so does not load acpi from QEMU. + * as such new acpi features don't work. + */ + { + .driver = "PIIX4_PM", + .property = "acpi-pci-hotplug-with-bridge-support", + .value = "off", + }, + { /* end of list */ } + }, }; #endif -- MST