From: Hani Benhabiles <kroosec@gmail.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 4/4] monitor: Add object_add class argument completion.
Date: Thu, 6 Feb 2014 23:30:13 +0100 [thread overview]
Message-ID: <1391725813-29514-5-git-send-email-kroosec@gmail.com> (raw)
In-Reply-To: <1391725813-29514-1-git-send-email-kroosec@gmail.com>
---
monitor.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/monitor.c b/monitor.c
index 4a2c1ae..397e1fe 100644
--- a/monitor.c
+++ b/monitor.c
@@ -56,6 +56,7 @@
#include "qapi/qmp/qjson.h"
#include "qapi/qmp/json-streamer.h"
#include "qapi/qmp/json-parser.h"
+#include <qom/object_interfaces.h>
#include "qemu/osdep.h"
#include "cpu.h"
#include "trace.h"
@@ -4275,6 +4276,26 @@ static void device_add_completion(ReadLineState *rs, const char *str)
g_slist_free(list);
}
+static void object_add_completion(ReadLineState *rs, const char *str)
+{
+ GSList *list, *elt;
+ size_t len;
+
+ len = strlen(str);
+ readline_set_completion_index(rs, len);
+ list = elt = object_class_get_list(TYPE_USER_CREATABLE, false);
+ while (elt) {
+ const char *name;
+
+ name = object_class_get_name(OBJECT_CLASS(elt->data));
+ if (!strncmp(name, str, len) && strcmp(name, TYPE_USER_CREATABLE)) {
+ readline_add_completion(rs, name);
+ }
+ elt = elt->next;
+ }
+ g_slist_free(list);
+}
+
static void device_del_completion(ReadLineState *rs, BusState *bus,
const char *str, size_t len)
{
@@ -4381,6 +4402,8 @@ static void monitor_find_completion_by_table(Monitor *mon,
case 'O':
if (!strcmp(cmd->name, "device_add") && nb_args == 2) {
device_add_completion(mon->rs, str);
+ } else if (!strcmp(cmd->name, "object_add") && nb_args == 2) {
+ object_add_completion(mon->rs, str);
}
break;
case 's':
--
1.8.3.2
next prev parent reply other threads:[~2014-02-06 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 22:30 [Qemu-devel] [PATCH 0/4] monitor: Add argument completion for multiple commands Hani Benhabiles
2014-02-06 22:30 ` [Qemu-devel] [PATCH 1/4] monitor: Add device_del id argument completion Hani Benhabiles
2014-02-11 18:35 ` Luiz Capitulino
2014-02-06 22:30 ` [Qemu-devel] [PATCH 2/4] monitor: Add device_add device " Hani Benhabiles
2014-02-06 22:30 ` [Qemu-devel] [PATCH 3/4] monitor: Add object_del id " Hani Benhabiles
2014-02-06 22:30 ` Hani Benhabiles [this message]
2014-02-11 18:38 ` [Qemu-devel] [PATCH 4/4] monitor: Add object_add class " Luiz Capitulino
2014-02-11 22:14 ` Hani Benhabiles
2014-02-11 18:39 ` [Qemu-devel] [PATCH 0/4] monitor: Add argument completion for multiple commands Luiz Capitulino
2014-02-11 22:10 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391725813-29514-5-git-send-email-kroosec@gmail.com \
--to=kroosec@gmail.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).