From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit.canet@irqsave.net>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v2 1/5] qemu-io: Account IO by aio_read and aio_write
Date: Fri, 7 Feb 2014 18:43:29 +0800 [thread overview]
Message-ID: <1391769813-15437-2-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1391769813-15437-1-git-send-email-famz@redhat.com>
This will enable accounting of aio requests issued from qemu-io aio
read/write commands.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
qemu-io-cmds.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index f1de24c..d68eb23 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -1346,6 +1346,7 @@ out:
}
struct aio_ctx {
+ BlockDriverState *bs;
QEMUIOVector qiov;
int64_t offset;
char *buf;
@@ -1353,6 +1354,7 @@ struct aio_ctx {
int vflag;
int Cflag;
int Pflag;
+ BlockAcctCookie acct;
int pattern;
struct timeval t1;
};
@@ -1370,6 +1372,8 @@ static void aio_write_done(void *opaque, int ret)
goto out;
}
+ bdrv_acct_done(ctx->bs, &ctx->acct);
+
if (ctx->qflag) {
goto out;
}
@@ -1407,6 +1411,8 @@ static void aio_read_done(void *opaque, int ret)
g_free(cmp_buf);
}
+ bdrv_acct_done(ctx->bs, &ctx->acct);
+
if (ctx->qflag) {
goto out;
}
@@ -1462,6 +1468,7 @@ static int aio_read_f(BlockDriverState *bs, int argc, char **argv)
int nr_iov, c;
struct aio_ctx *ctx = g_new0(struct aio_ctx, 1);
+ ctx->bs = bs;
while ((c = getopt(argc, argv, "CP:qv")) != EOF) {
switch (c) {
case 'C':
@@ -1515,6 +1522,7 @@ static int aio_read_f(BlockDriverState *bs, int argc, char **argv)
}
gettimeofday(&ctx->t1, NULL);
+ bdrv_acct_start(bs, &ctx->acct, ctx->qiov.size, BDRV_ACCT_READ);
bdrv_aio_readv(bs, ctx->offset >> 9, &ctx->qiov,
ctx->qiov.size >> 9, aio_read_done, ctx);
return 0;
@@ -1558,6 +1566,7 @@ static int aio_write_f(BlockDriverState *bs, int argc, char **argv)
int pattern = 0xcd;
struct aio_ctx *ctx = g_new0(struct aio_ctx, 1);
+ ctx->bs = bs;
while ((c = getopt(argc, argv, "CqP:")) != EOF) {
switch (c) {
case 'C':
@@ -1607,6 +1616,7 @@ static int aio_write_f(BlockDriverState *bs, int argc, char **argv)
}
gettimeofday(&ctx->t1, NULL);
+ bdrv_acct_start(bs, &ctx->acct, ctx->qiov.size, BDRV_ACCT_WRITE);
bdrv_aio_writev(bs, ctx->offset >> 9, &ctx->qiov,
ctx->qiov.size >> 9, aio_write_done, ctx);
return 0;
--
1.8.5.4
next prev parent reply other threads:[~2014-02-07 10:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 10:43 [Qemu-devel] [PATCH v2 0/5] qemu-iotests: Test case for IO throttling Fam Zheng
2014-02-07 10:43 ` Fam Zheng [this message]
2014-02-10 11:49 ` [Qemu-devel] [PATCH v2 1/5] qemu-io: Account IO by aio_read and aio_write Benoît Canet
2014-02-07 10:43 ` [Qemu-devel] [PATCH v2 2/5] qtest: Add scripts/qtest/qtest.py Fam Zheng
2014-02-10 12:04 ` Benoît Canet
2014-02-07 10:43 ` [Qemu-devel] [PATCH v2 3/5] qemu-iotests: Add VM method qtest() to iotests.py Fam Zheng
2014-02-10 12:11 ` Benoît Canet
2014-02-07 10:43 ` [Qemu-devel] [PATCH v2 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp Fam Zheng
2014-02-07 10:43 ` [Qemu-devel] [PATCH v2 5/5] qemu-iotests: Add 080 for IO throttling Fam Zheng
2014-02-10 12:32 ` Benoît Canet
2014-02-11 6:39 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391769813-15437-2-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).