qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
	Thomas Huth <thuth@linux.vnet.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	Dominik Dingel <dingel@linux.vnet.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Jens Freimann <jfrei@linux.vnet.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [Patch/RFC 12/16] s390x/sclp: Fixed setting of condition code register
Date: Fri,  7 Feb 2014 18:16:21 +0100	[thread overview]
Message-ID: <1391793385-46694-13-git-send-email-borntraeger@de.ibm.com> (raw)
In-Reply-To: <1391793385-46694-1-git-send-email-borntraeger@de.ibm.com>

From: Thomas Huth <thuth@linux.vnet.ibm.com>

In the SCLP handler function, the condition code register must
only be set if no exception occured.

Signed-off-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 target-s390x/kvm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index ea3d652..20c711f 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -451,8 +451,9 @@ static int kvm_sclp_service_call(S390CPU *cpu, struct kvm_run *run,
     r = sclp_service_call(env, sccb, code);
     if (r < 0) {
         enter_pgmcheck(cpu, -r);
+    } else {
+        setcc(cpu, r);
     }
-    setcc(cpu, r);
 
     return 0;
 }
-- 
1.8.4.2

  parent reply	other threads:[~2014-02-07 17:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 17:16 [Qemu-devel] [Patch/RFC 00/16] s390x/kvm features and fixes Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 01/16] update linux headers to kvm/next Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 02/16] s390x/kvm: implement floating-interrupt controller device Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 03/16] s390x/async_pf: Check for apf extension and enable pfault Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 04/16] s390x/kvm: Fixed bad SIGP SET-ARCHITECTURE handler Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 05/16] s390x/kvm: Rework SIGP INITIAL CPU RESET handler Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 06/16] s390x/kvm: Add missing SIGP CPU RESET order Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 07/16] s390x/virtio-hcall: Add range check for hypervisor call Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 08/16] s390x/virtio-hcall: Specification exception for illegal subcodes Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 09/16] s390x/eventfacility: mask out commands Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 10/16] s390x/sclp: Fixed the size of sccb and code parameter Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 11/16] s390x/sclp: Add missing checks to SCLP handler Christian Borntraeger
2014-02-07 17:16 ` Christian Borntraeger [this message]
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 13/16] s390x/event-facility: some renaming Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 14/16] s390x/event-facility: code restructure Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 15/16] s390x/event-facility: add support for live migration Christian Borntraeger
2014-02-07 17:16 ` [Qemu-devel] [Patch/RFC 16/16] s390x/event-facility: exploit realize/unrealize Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391793385-46694-13-git-send-email-borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=dingel@linux.vnet.ibm.com \
    --cc=graalfs@linux.vnet.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).