From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCQ2c-0003fS-HA for qemu-devel@nongnu.org; Sun, 09 Feb 2014 03:47:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCQ2W-0001AE-HF for qemu-devel@nongnu.org; Sun, 09 Feb 2014 03:47:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCQ2W-0001A8-9X for qemu-devel@nongnu.org; Sun, 09 Feb 2014 03:47:00 -0500 From: Kevin Wolf Date: Sun, 9 Feb 2014 09:46:26 +0100 Message-Id: <1391935590-12264-15-git-send-email-kwolf@redhat.com> In-Reply-To: <1391935590-12264-1-git-send-email-kwolf@redhat.com> References: <1391935590-12264-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 14/18] block: Fix memory leaks in bdrv_co_do_pwritev() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org The error path for a failure in one of the two bdrv_aligned_preadv() calls leaked head_buf or tail_buf, respectively. This fixes the memory leak. Reported-by: Laszlo Ersek Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Laszlo Ersek --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index ac0ccac..c1d1f74 100644 --- a/block.c +++ b/block.c @@ -3279,9 +3279,9 @@ fail: if (use_local_qiov) { qemu_iovec_destroy(&local_qiov); - qemu_vfree(head_buf); - qemu_vfree(tail_buf); } + qemu_vfree(head_buf); + qemu_vfree(tail_buf); return ret; } -- 1.8.1.4