* [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include
@ 2014-02-09 9:02 Kevin Wolf
2014-02-10 7:00 ` Fam Zheng
2014-02-10 16:47 ` Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: Kevin Wolf @ 2014-02-09 9:02 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, stefanha
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/sd/sdhci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 0906a1d..a0b90ba 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -26,7 +26,6 @@
#include "sysemu/blockdev.h"
#include "sysemu/dma.h"
#include "qemu/timer.h"
-#include "block/block_int.h"
#include "qemu/bitops.h"
#include "sdhci.h"
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include
2014-02-09 9:02 [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include Kevin Wolf
@ 2014-02-10 7:00 ` Fam Zheng
2014-02-10 10:18 ` Kevin Wolf
2014-02-10 16:47 ` Stefan Hajnoczi
1 sibling, 1 reply; 4+ messages in thread
From: Fam Zheng @ 2014-02-10 7:00 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, stefanha
On Sun, 02/09 10:02, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/sd/sdhci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index 0906a1d..a0b90ba 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -26,7 +26,6 @@
> #include "sysemu/blockdev.h"
> #include "sysemu/dma.h"
> #include "qemu/timer.h"
> -#include "block/block_int.h"
> #include "qemu/bitops.h"
>
> #include "sdhci.h"
> --
> 1.8.1.4
>
Reviewed-by: Fam Zheng <famz@redhat.com>
BTW it seems bitops.h is not used too, although I'm not 100% sure.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include
2014-02-10 7:00 ` Fam Zheng
@ 2014-02-10 10:18 ` Kevin Wolf
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2014-02-10 10:18 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, stefanha
Am 10.02.2014 um 08:00 hat Fam Zheng geschrieben:
> On Sun, 02/09 10:02, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > hw/sd/sdhci.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> > index 0906a1d..a0b90ba 100644
> > --- a/hw/sd/sdhci.c
> > +++ b/hw/sd/sdhci.c
> > @@ -26,7 +26,6 @@
> > #include "sysemu/blockdev.h"
> > #include "sysemu/dma.h"
> > #include "qemu/timer.h"
> > -#include "block/block_int.h"
> > #include "qemu/bitops.h"
> >
> > #include "sdhci.h"
> > --
> > 1.8.1.4
> >
>
> Reviewed-by: Fam Zheng <famz@redhat.com>
>
> BTW it seems bitops.h is not used too, although I'm not 100% sure.
Not sure, you'd have to try it out.
The main reason for this removal is that it is the last user of
block_int.h in hw/
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include
2014-02-09 9:02 [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include Kevin Wolf
2014-02-10 7:00 ` Fam Zheng
@ 2014-02-10 16:47 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2014-02-10 16:47 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On Sun, Feb 09, 2014 at 10:02:27AM +0100, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> hw/sd/sdhci.c | 1 -
> 1 file changed, 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-10 16:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-09 9:02 [Qemu-devel] [PATCH] sdhci: Drop unnecessary #include Kevin Wolf
2014-02-10 7:00 ` Fam Zheng
2014-02-10 10:18 ` Kevin Wolf
2014-02-10 16:47 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).