From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCR0p-0008OW-Sh for qemu-devel@nongnu.org; Sun, 09 Feb 2014 04:49:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCR0h-0007hc-Bo for qemu-devel@nongnu.org; Sun, 09 Feb 2014 04:49:19 -0500 Received: from mail-ea0-x232.google.com ([2a00:1450:4013:c01::232]:33470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCR0h-0007hW-3y for qemu-devel@nongnu.org; Sun, 09 Feb 2014 04:49:11 -0500 Received: by mail-ea0-f178.google.com with SMTP id a15so2433109eae.9 for ; Sun, 09 Feb 2014 01:49:10 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Sun, 9 Feb 2014 10:48:38 +0100 Message-Id: <1391939335-31580-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1391939335-31580-1-git-send-email-pbonzini@redhat.com> References: <1391939335-31580-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 03/20] nbd: inline tcp_socket_incoming_spec into sole caller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, mreitz@redhat.com Signed-off-by: Paolo Bonzini --- include/block/nbd.h | 1 - nbd.c | 8 ++------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/block/nbd.h b/include/block/nbd.h index e10ab82..1b39c06 100644 --- a/include/block/nbd.h +++ b/include/block/nbd.h @@ -63,7 +63,6 @@ enum { ssize_t nbd_wr_sync(int fd, void *buffer, size_t size, bool do_read); int tcp_socket_incoming(const char *address, uint16_t port); -int tcp_socket_incoming_spec(const char *address_and_port); int unix_socket_outgoing(const char *path); int unix_socket_incoming(const char *path); diff --git a/nbd.c b/nbd.c index 17ca95b..2fc1f1f 100644 --- a/nbd.c +++ b/nbd.c @@ -202,13 +202,9 @@ static void combine_addr(char *buf, size_t len, const char* address, int tcp_socket_incoming(const char *address, uint16_t port) { char address_and_port[128]; - combine_addr(address_and_port, 128, address, port); - return tcp_socket_incoming_spec(address_and_port); -} - -int tcp_socket_incoming_spec(const char *address_and_port) -{ Error *local_err = NULL; + + combine_addr(address_and_port, 128, address, port); int fd = inet_listen(address_and_port, NULL, 0, SOCK_STREAM, 0, &local_err); if (local_err != NULL) { -- 1.8.5.3