qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
	mdroth@linux.vnet.ibm.com, aliguori@amazon.com,
	pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str()
Date: Mon, 10 Feb 2014 15:20:44 +0100	[thread overview]
Message-ID: <1392042045-31525-13-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1392042045-31525-1-git-send-email-armbru@redhat.com>

Argument can't be null.  No other Visitor method type_str() checks for
null.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/qapi-dealloc-visitor.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c
index dc53545..d0ea118 100644
--- a/qapi/qapi-dealloc-visitor.c
+++ b/qapi/qapi-dealloc-visitor.c
@@ -131,9 +131,7 @@ static void qapi_dealloc_end_list(Visitor *v, Error **errp)
 static void qapi_dealloc_type_str(Visitor *v, char **obj, const char *name,
                                   Error **errp)
 {
-    if (obj) {
-        g_free(*obj);
-    }
+    g_free(*obj);
 }
 
 static void qapi_dealloc_type_int(Visitor *v, int64_t *obj, const char *name,
-- 
1.8.1.4

  parent reply	other threads:[~2014-02-10 14:21 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 14:20 [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 01/13] tests/qapi-schema: Actually check successful QMP command response Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 02/13] tests/qapi-schema: Cover optional command arguments Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 03/13] tests/qapi-schema: Cover simple argument types Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 04/13] tests/qapi-schema: Cover anonymous union types Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 05/13] tests/qapi-schema: Cover complex types with base Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 06/13] tests/qapi-schema: Cover union " Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 07/13] tests/qapi-schema: Cover flat union types Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 08/13] qapi: Fix licensing of scripts Markus Armbruster
2014-02-10 15:26   ` Eric Blake
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 10/13] qapi: Drop unused code in qapi-commands.py Markus Armbruster
2014-02-10 14:20 ` [Qemu-devel] [PATCH v2 11/13] qapi: Clean up null checking in generated visitors Markus Armbruster
2014-02-10 14:20 ` Markus Armbruster [this message]
2014-02-10 15:27   ` [Qemu-devel] [PATCH 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str() Eric Blake
2014-02-10 14:20 ` [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct() Markus Armbruster
2014-02-10 15:28   ` Eric Blake
2014-02-13  9:30     ` Paolo Bonzini
2014-02-13  9:31 ` [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code Paolo Bonzini
2014-02-13 13:41   ` Luiz Capitulino
2014-02-13 13:57     ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392042045-31525-13-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=kwolf@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).