From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDM6Q-0005Q5-9A for qemu-devel@nongnu.org; Tue, 11 Feb 2014 17:46:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDM6K-0003Z5-N1 for qemu-devel@nongnu.org; Tue, 11 Feb 2014 17:46:54 -0500 Received: from smtp4-g21.free.fr ([2a01:e0c:1:1599::13]:55713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDM6K-0003Yd-3d for qemu-devel@nongnu.org; Tue, 11 Feb 2014 17:46:48 -0500 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Tue, 11 Feb 2014 23:46:02 +0100 Message-Id: <1392158763-6552-2-git-send-email-hpoussin@reactos.org> In-Reply-To: <1392158763-6552-1-git-send-email-hpoussin@reactos.org> References: <1392158763-6552-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 1/2] pam: partly fix write-only mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Anthony Liguori , "Michael S. Tsirkin" In write-only mode, writes are forwarded to RAM, while reads should not b= e handled (ie should return 0xff). Assume that in this mode, no read access is ever done, as they shouldn't give any sensible result. So, in write-only mode, alias PAM region to RAM, instead of PCI memory (which can even be mapped to some device!) This fixes Award BIOS, which use this mode to shadow system BIOS and vide= o BIOS. Signed-off-by: Herv=C3=A9 Poussineau --- hw/pci-host/pam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/pam.c b/hw/pci-host/pam.c index ec6be46..e1e95aa 100644 --- a/hw/pci-host/pam.c +++ b/hw/pci-host/pam.c @@ -68,7 +68,7 @@ void init_pam(DeviceState *dev, MemoryRegion *ram_memor= y, /* XXX: should distinguish read/write cases */ memory_region_init_alias(&mem->alias[0], OBJECT(dev), "pam-pci", pci= _address_space, start, size); - memory_region_init_alias(&mem->alias[2], OBJECT(dev), "pam-pci", pci= _address_space, + memory_region_init_alias(&mem->alias[2], OBJECT(dev), "pam-pci", ram= _memory, start, size); =20 for (i =3D 0; i < 4; ++i) { --=20 1.7.10.4