From: Chunyan Liu <cyliu@suse.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>,
Chunyan Liu <cyliu@suse.com>,
stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v20 19/26] ssh.c: replace QEMUOptionParameter with QemuOpts
Date: Wed, 12 Feb 2014 14:33:19 +0800 [thread overview]
Message-ID: <1392186806-10418-20-git-send-email-cyliu@suse.com> (raw)
In-Reply-To: <1392186806-10418-1-git-send-email-cyliu@suse.com>
ssh.c: replace QEMUOptionParameter with QemuOpts
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
block/ssh.c | 31 +++++++++++++++----------------
1 files changed, 15 insertions(+), 16 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index aa63c9d..8fd2175 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -642,16 +642,20 @@ static int ssh_file_open(BlockDriverState *bs, QDict *options, int bdrv_flags,
return ret;
}
-static QEMUOptionParameter ssh_create_options[] = {
- {
- .name = BLOCK_OPT_SIZE,
- .type = OPT_SIZE,
- .help = "Virtual disk size"
- },
- { NULL }
+static QemuOptsList ssh_create_opts = {
+ .name = "ssh-create-opts",
+ .head = QTAILQ_HEAD_INITIALIZER(ssh_create_opts.head),
+ .desc = {
+ {
+ .name = BLOCK_OPT_SIZE,
+ .type = QEMU_OPT_SIZE,
+ .help = "Virtual disk size"
+ },
+ { /* end of list */ }
+ }
};
-static int ssh_create(const char *filename, QEMUOptionParameter *options,
+static int ssh_create(const char *filename, QemuOpts *opts,
Error **errp)
{
int r, ret;
@@ -665,12 +669,7 @@ static int ssh_create(const char *filename, QEMUOptionParameter *options,
ssh_state_init(&s);
/* Get desired file size. */
- while (options && options->name) {
- if (!strcmp(options->name, BLOCK_OPT_SIZE)) {
- total_size = options->value.n;
- }
- options++;
- }
+ total_size = qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0);
DPRINTF("total_size=%" PRIi64, total_size);
uri_options = qdict_new();
@@ -1044,14 +1043,14 @@ static BlockDriver bdrv_ssh = {
.instance_size = sizeof(BDRVSSHState),
.bdrv_parse_filename = ssh_parse_filename,
.bdrv_file_open = ssh_file_open,
- .bdrv_create = ssh_create,
+ .bdrv_create2 = ssh_create,
.bdrv_close = ssh_close,
.bdrv_has_zero_init = ssh_has_zero_init,
.bdrv_co_readv = ssh_co_readv,
.bdrv_co_writev = ssh_co_writev,
.bdrv_getlength = ssh_getlength,
.bdrv_co_flush_to_disk = ssh_co_flush,
- .create_options = ssh_create_options,
+ .create_opts = &ssh_create_opts,
};
static void bdrv_ssh_init(void)
--
1.6.0.2
next prev parent reply other threads:[~2014-02-12 6:33 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 6:33 [Qemu-devel] [PATCH v20 00/26] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 01/26] add def_value_str to QemuOptDesc Chunyan Liu
2014-02-12 23:00 ` Eric Blake
2014-02-18 7:06 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 02/26] qapi: output def_value_str when query command line options Chunyan Liu
2014-02-12 23:05 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 03/26] improve some functions in qemu-option.c Chunyan Liu
2014-02-12 23:22 ` Eric Blake
2014-02-18 6:28 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 04/26] add some QemuOpts functions for replace work Chunyan Liu
2014-02-12 23:31 ` Eric Blake
2014-02-18 6:43 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 05/26] remove assertion of qemu_opt_get functions Chunyan Liu
2014-02-12 23:50 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 06/26] change block layer to support both QemuOpts and QEMUOptionParameter Chunyan Liu
2014-02-13 0:12 ` Eric Blake
2014-02-18 6:44 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 07/26] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-13 0:19 ` Eric Blake
2014-02-18 7:15 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 08/26] gluster.c: " Chunyan Liu
2014-02-13 0:21 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 09/26] iscsi.c: " Chunyan Liu
2014-02-13 0:22 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 10/26] qcow.c: " Chunyan Liu
2014-02-13 0:24 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 11/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in create Chunyan Liu
2014-02-13 0:30 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 12/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in amend options Chunyan Liu
2014-02-17 17:57 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 13/26] qed.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-17 18:01 ` Eric Blake
2014-02-18 7:42 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 14/26] raw-posix.c: " Chunyan Liu
2014-02-17 18:18 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 15/26] raw-win32.c: " Chunyan Liu
2014-02-17 18:42 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 16/26] raw_bsd.c: " Chunyan Liu
2014-02-17 18:49 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 17/26] rbd.c: " Chunyan Liu
2014-02-17 18:57 ` Eric Blake
2014-02-18 5:56 ` Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 18/26] sheepdog.c: " Chunyan Liu
2014-02-17 19:01 ` Eric Blake
2014-02-18 8:18 ` Chunyan Liu
2014-02-12 6:33 ` Chunyan Liu [this message]
2014-02-17 23:26 ` [Qemu-devel] [PATCH v20 19/26] ssh.c: " Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 20/26] vdi.c: " Chunyan Liu
2014-02-18 0:00 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 21/26] vmdk.c: " Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 22/26] vpc.c: " Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 23/26] vhdx.c: " Chunyan Liu
2014-02-19 18:38 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 24/26] vvfat.c: " Chunyan Liu
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 25/26] cleanup QEMUOptionParameter Chunyan Liu
2014-02-13 0:35 ` Eric Blake
2014-02-12 6:33 ` [Qemu-devel] [PATCH v20 26/26] change back to original name from bdrv_create2 to bdrv_create Chunyan Liu
2014-02-13 0:32 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392186806-10418-20-git-send-email-cyliu@suse.com \
--to=cyliu@suse.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).