qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Chunyan Liu <cyliu@suse.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>,
	Chunyan Liu <cyliu@suse.com>,
	stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v20 07/26] cow.c: replace QEMUOptionParameter with QemuOpts
Date: Wed, 12 Feb 2014 14:33:07 +0800	[thread overview]
Message-ID: <1392186806-10418-8-git-send-email-cyliu@suse.com> (raw)
In-Reply-To: <1392186806-10418-1-git-send-email-cyliu@suse.com>

cow.c: replace QEMUOptionParameter with QemuOpts

Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
 block/cow.c |   46 ++++++++++++++++++++++------------------------
 1 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/block/cow.c b/block/cow.c
index 85c2971..0d06781 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -323,7 +323,7 @@ static void cow_close(BlockDriverState *bs)
 {
 }
 
-static int cow_create(const char *filename, QEMUOptionParameter *options,
+static int cow_create(const char *filename, QemuOpts *opts,
                       Error **errp)
 {
     struct cow_header_v2 cow_header;
@@ -335,16 +335,10 @@ static int cow_create(const char *filename, QEMUOptionParameter *options,
     BlockDriverState *cow_bs;
 
     /* Read out options */
-    while (options && options->name) {
-        if (!strcmp(options->name, BLOCK_OPT_SIZE)) {
-            image_sectors = options->value.n / 512;
-        } else if (!strcmp(options->name, BLOCK_OPT_BACKING_FILE)) {
-            image_filename = options->value.s;
-        }
-        options++;
-    }
+    image_sectors = qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0) / 512;
+    image_filename = qemu_opt_get_del(opts, BLOCK_OPT_BACKING_FILE);
 
-    ret = bdrv_create_file(filename, options, NULL, &local_err);
+    ret = bdrv_create_file(filename, NULL, opts, &local_err);
     if (ret < 0) {
         qerror_report_err(local_err);
         error_free(local_err);
@@ -393,18 +387,22 @@ exit:
     return ret;
 }
 
-static QEMUOptionParameter cow_create_options[] = {
-    {
-        .name = BLOCK_OPT_SIZE,
-        .type = OPT_SIZE,
-        .help = "Virtual disk size"
-    },
-    {
-        .name = BLOCK_OPT_BACKING_FILE,
-        .type = OPT_STRING,
-        .help = "File name of a base image"
-    },
-    { NULL }
+static QemuOptsList cow_create_opts = {
+    .name = "cow-create-opts",
+    .head = QTAILQ_HEAD_INITIALIZER(cow_create_opts.head),
+    .desc = {
+        {
+            .name = BLOCK_OPT_SIZE,
+            .type = QEMU_OPT_SIZE,
+            .help = "Virtual disk size"
+        },
+        {
+            .name = BLOCK_OPT_BACKING_FILE,
+            .type = QEMU_OPT_STRING,
+            .help = "File name of a base image"
+        },
+        { /* end of list */ }
+    }
 };
 
 static BlockDriver bdrv_cow = {
@@ -414,14 +412,14 @@ static BlockDriver bdrv_cow = {
     .bdrv_probe     = cow_probe,
     .bdrv_open      = cow_open,
     .bdrv_close     = cow_close,
-    .bdrv_create    = cow_create,
+    .bdrv_create2    = cow_create,
     .bdrv_has_zero_init     = bdrv_has_zero_init_1,
 
     .bdrv_read              = cow_co_read,
     .bdrv_write             = cow_co_write,
     .bdrv_co_get_block_status   = cow_co_get_block_status,
 
-    .create_options = cow_create_options,
+    .create_opts       = &cow_create_opts,
 };
 
 static void bdrv_cow_init(void)
-- 
1.6.0.2

  parent reply	other threads:[~2014-02-12  6:33 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12  6:33 [Qemu-devel] [PATCH v20 00/26] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 01/26] add def_value_str to QemuOptDesc Chunyan Liu
2014-02-12 23:00   ` Eric Blake
2014-02-18  7:06     ` Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 02/26] qapi: output def_value_str when query command line options Chunyan Liu
2014-02-12 23:05   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 03/26] improve some functions in qemu-option.c Chunyan Liu
2014-02-12 23:22   ` Eric Blake
2014-02-18  6:28     ` Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 04/26] add some QemuOpts functions for replace work Chunyan Liu
2014-02-12 23:31   ` Eric Blake
2014-02-18  6:43     ` Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 05/26] remove assertion of qemu_opt_get functions Chunyan Liu
2014-02-12 23:50   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 06/26] change block layer to support both QemuOpts and QEMUOptionParameter Chunyan Liu
2014-02-13  0:12   ` Eric Blake
2014-02-18  6:44     ` Chunyan Liu
2014-02-12  6:33 ` Chunyan Liu [this message]
2014-02-13  0:19   ` [Qemu-devel] [PATCH v20 07/26] cow.c: replace QEMUOptionParameter with QemuOpts Eric Blake
2014-02-18  7:15     ` Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 08/26] gluster.c: " Chunyan Liu
2014-02-13  0:21   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 09/26] iscsi.c: " Chunyan Liu
2014-02-13  0:22   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 10/26] qcow.c: " Chunyan Liu
2014-02-13  0:24   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 11/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in create Chunyan Liu
2014-02-13  0:30   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 12/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in amend options Chunyan Liu
2014-02-17 17:57   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 13/26] qed.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-17 18:01   ` Eric Blake
2014-02-18  7:42     ` Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 14/26] raw-posix.c: " Chunyan Liu
2014-02-17 18:18   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 15/26] raw-win32.c: " Chunyan Liu
2014-02-17 18:42   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 16/26] raw_bsd.c: " Chunyan Liu
2014-02-17 18:49   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 17/26] rbd.c: " Chunyan Liu
2014-02-17 18:57   ` Eric Blake
2014-02-18  5:56     ` Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 18/26] sheepdog.c: " Chunyan Liu
2014-02-17 19:01   ` Eric Blake
2014-02-18  8:18     ` Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 19/26] ssh.c: " Chunyan Liu
2014-02-17 23:26   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 20/26] vdi.c: " Chunyan Liu
2014-02-18  0:00   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 21/26] vmdk.c: " Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 22/26] vpc.c: " Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 23/26] vhdx.c: " Chunyan Liu
2014-02-19 18:38   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 24/26] vvfat.c: " Chunyan Liu
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 25/26] cleanup QEMUOptionParameter Chunyan Liu
2014-02-13  0:35   ` Eric Blake
2014-02-12  6:33 ` [Qemu-devel] [PATCH v20 26/26] change back to original name from bdrv_create2 to bdrv_create Chunyan Liu
2014-02-13  0:32   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392186806-10418-8-git-send-email-cyliu@suse.com \
    --to=cyliu@suse.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wdongxu@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).