From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDknO-0001D9-Ts for qemu-devel@nongnu.org; Wed, 12 Feb 2014 20:09:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDknF-0000hQ-Tv for qemu-devel@nongnu.org; Wed, 12 Feb 2014 20:08:54 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:53051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDknF-0000gu-5y for qemu-devel@nongnu.org; Wed, 12 Feb 2014 20:08:45 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Feb 2014 11:08:41 +1000 From: Alexey Kardashevskiy Date: Thu, 13 Feb 2014 12:08:35 +1100 Message-Id: <1392253715-5416-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [PATCH] xics-kvm: fix reset function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, Alexander Graf Currently interrupt priorities are set to 0 (highest) at the very beginning of the guest execution which is not correct and makes the guest produce random interrupt error messages such as: "Interrupt 0x1001 (real) is invalid, disabling it". This also prevents interrupt states from correct migration. This initializes priority to 0xFF as the emulated XICS does. Signed-off-by: Alexey Kardashevskiy --- hw/intc/xics_kvm.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c index c203646..eaf94d9 100644 --- a/hw/intc/xics_kvm.c +++ b/hw/intc/xics_kvm.c @@ -269,6 +269,15 @@ static void ics_kvm_set_irq(void *opaque, int srcno, int val) static void ics_kvm_reset(DeviceState *dev) { + ICSState *ics = ICS(dev); + int i; + + memset(ics->irqs, 0, sizeof(ICSIRQState) * ics->nr_irqs); + for (i = 0; i < ics->nr_irqs; i++) { + ics->irqs[i].priority = 0xff; + ics->irqs[i].saved_priority = 0xff; + } + ics_set_kvm_state(ICS(dev), 1); } -- 1.8.4.rc4