From: "Benoît Canet" <benoit.canet@irqsave.net>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, "Benoît Canet" <benoit.canet@irqsave.net>,
famz@redhat.com, jcody@redhat.com, armbru@redhat.com,
mreitz@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [FIX V2] repair snapshots
Date: Thu, 13 Feb 2014 02:51:36 +0100 [thread overview]
Message-ID: <1392256297-21782-1-git-send-email-benoit.canet@irqsave.net> (raw)
This patch fix the snapshoting code.
When initially testing block filter snapshots patches and quorum I used a wrong
quorum command line which containned an extra top level "file."
As a result quorum was encapsulated in a top level bs.
This caused me to write and test against the wrong configuration and
break snapshot.
This patch implement Kevin sugestion for the fix.
I tested
snapshot of a Blockbackend: ex virtio0 ok
snapshot of a quorum file instantiated in the command line. ok
snapshot of a quorum file instantiated via blockdev_add by references ok
snapshot of a quorum file instianciated via blockdev without references ok
A comment update for quorum will be needed to avoid user to use the wrong
command line.
Benoît Canet (1):
block: Fix device snapshots broken by the block filter snapshots
patchset.
block.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--
1.8.3.2
next reply other threads:[~2014-02-13 1:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 1:51 Benoît Canet [this message]
2014-02-13 1:51 ` [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset Benoît Canet
2014-02-13 8:33 ` Kevin Wolf
2014-02-13 8:44 ` Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392256297-21782-1-git-send-email-benoit.canet@irqsave.net \
--to=benoit.canet@irqsave.net \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).