From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDlSq-0002In-QM for qemu-devel@nongnu.org; Wed, 12 Feb 2014 20:51:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDlSk-00077m-Re for qemu-devel@nongnu.org; Wed, 12 Feb 2014 20:51:44 -0500 Received: from paradis.irqsave.net ([62.212.105.220]:49876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDlSk-00077f-Il for qemu-devel@nongnu.org; Wed, 12 Feb 2014 20:51:38 -0500 From: =?UTF-8?q?Beno=C3=AEt=20Canet?= Date: Thu, 13 Feb 2014 02:51:36 +0100 Message-Id: <1392256297-21782-1-git-send-email-benoit.canet@irqsave.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [FIX V2] repair snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, =?UTF-8?q?Beno=C3=AEt=20Canet?= , famz@redhat.com, jcody@redhat.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com This patch fix the snapshoting code. When initially testing block filter snapshots patches and quorum I used a= wrong quorum command line which containned an extra top level "file." As a result quorum was encapsulated in a top level bs. This caused me to write and test against the wrong configuration and break snapshot. This patch implement Kevin sugestion for the fix. I tested snapshot of a Blockbackend: ex virtio0 ok snapshot of a quorum file instantiated in the command line. ok snapshot of a quorum file instantiated via blockdev_add by references ok snapshot of a quorum file instianciated via blockdev without references o= k A comment update for quorum will be needed to avoid user to use the wrong command line. Beno=C3=AEt Canet (1): block: Fix device snapshots broken by the block filter snapshots patchset. block.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) --=20 1.8.3.2