From: edgar.iglesias@gmail.com
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, afaerber@suse.de, pcrost@xilinx.com
Subject: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state
Date: Thu, 13 Feb 2014 15:07:14 +1000 [thread overview]
Message-ID: <1392268034-6220-1-git-send-email-edgar.iglesias@gmail.com> (raw)
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
cpu->exit_request is part of the execution environment and should
not be cleared when a CPU resets.
Otherwise, we might deadlock QEMU if a CPU resets while there is
I/O going on.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
qom/cpu.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/qom/cpu.c b/qom/cpu.c
index 9d62479..40d82dd 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -195,7 +195,6 @@ static void cpu_common_reset(CPUState *cpu)
log_cpu_state(cpu, cc->reset_dump_flags);
}
- cpu->exit_request = 0;
cpu->interrupt_request = 0;
cpu->current_tb = NULL;
cpu->halted = 0;
--
1.8.1.2
next reply other threads:[~2014-02-13 5:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 5:07 edgar.iglesias [this message]
2014-02-15 15:42 ` [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state Peter Maydell
2014-02-16 2:07 ` Edgar E. Iglesias
2014-02-20 15:58 ` Peter Maydell
2014-02-20 16:15 ` Andreas Färber
2014-02-20 16:34 ` Peter Maydell
2014-02-20 23:26 ` Edgar E. Iglesias
2014-02-20 23:50 ` Peter Maydell
2014-03-11 23:58 ` Andreas Färber
2014-03-12 0:03 ` Peter Maydell
2014-03-12 1:51 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392268034-6220-1-git-send-email-edgar.iglesias@gmail.com \
--to=edgar.iglesias@gmail.com \
--cc=afaerber@suse.de \
--cc=pcrost@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).