From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDoWl-0003kE-UI for qemu-devel@nongnu.org; Thu, 13 Feb 2014 00:08:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WDoWg-0005ph-3X for qemu-devel@nongnu.org; Thu, 13 Feb 2014 00:07:59 -0500 Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:45150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WDoWf-0005pZ-VO for qemu-devel@nongnu.org; Thu, 13 Feb 2014 00:07:54 -0500 Received: by mail-qc0-f169.google.com with SMTP id w7so17279241qcr.0 for ; Wed, 12 Feb 2014 21:07:53 -0800 (PST) From: edgar.iglesias@gmail.com Date: Thu, 13 Feb 2014 15:07:14 +1000 Message-Id: <1392268034-6220-1-git-send-email-edgar.iglesias@gmail.com> Subject: [Qemu-devel] [PATCH] qom/cpu: Remove cpu->exit_request from reset state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, afaerber@suse.de, pcrost@xilinx.com From: "Edgar E. Iglesias" cpu->exit_request is part of the execution environment and should not be cleared when a CPU resets. Otherwise, we might deadlock QEMU if a CPU resets while there is I/O going on. Signed-off-by: Edgar E. Iglesias --- qom/cpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qom/cpu.c b/qom/cpu.c index 9d62479..40d82dd 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -195,7 +195,6 @@ static void cpu_common_reset(CPUState *cpu) log_cpu_state(cpu, cc->reset_dump_flags); } - cpu->exit_request = 0; cpu->interrupt_request = 0; cpu->current_tb = NULL; cpu->halted = 0; -- 1.8.1.2