From: Huw Davies <huw@codeweavers.com>
To: qemu devel <qemu-devel@nongnu.org>
Cc: Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH] tcg-arm: The shift count of op_rotl_i32 is in args[2] not args[1].
Date: Thu, 13 Feb 2014 10:26:46 +0000 [thread overview]
Message-ID: <1392287206-30889-1-git-send-email-huw@codeweavers.com> (raw)
It's this that should be subtracted from 0x20 when converting to a right rotate.
Signed-off-by: Huw Davies <huw@codeweavers.com>
---
tcg/arm/tcg-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
index 82658a1..c8884b3 100644
--- a/tcg/arm/tcg-target.c
+++ b/tcg/arm/tcg-target.c
@@ -1866,7 +1866,7 @@ static inline void tcg_out_op(TCGContext *s, TCGOpcode opc,
SHIFT_IMM_ROR((0x20 - args[2]) & 0x1f) :
SHIFT_IMM_LSL(0));
} else {
- tcg_out_dat_imm(s, COND_AL, ARITH_RSB, TCG_REG_TMP, args[1], 0x20);
+ tcg_out_dat_imm(s, COND_AL, ARITH_RSB, TCG_REG_TMP, args[2], 0x20);
tcg_out_dat_reg(s, COND_AL, ARITH_MOV, args[0], 0, args[1],
SHIFT_REG_ROR(TCG_REG_TMP));
}
--
1.8.0
next reply other threads:[~2014-02-13 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-13 10:26 Huw Davies [this message]
2014-02-13 14:59 ` [Qemu-devel] [PATCH] tcg-arm: The shift count of op_rotl_i32 is in args[2] not args[1] Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392287206-30889-1-git-send-email-huw@codeweavers.com \
--to=huw@codeweavers.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).