qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH 1/4] gtk: Use gtk generic event signal instead of motion-notify-event
Date: Thu, 13 Feb 2014 12:15:36 +0100	[thread overview]
Message-ID: <1392290139-17250-2-git-send-email-tiwai@suse.de> (raw)
In-Reply-To: <1392290139-17250-1-git-send-email-tiwai@suse.de>

The GDK motion-notify-event isn't generated when the pointer goes out
of the target window even if the pointer is grabbed, which essentially
means to lose the pointer tracking in gtk-ui.

Meanwhile the generic "event" signal is sent when the pointer is
grabbed, so we can use this and pick the motion notify events manually
there instead.

Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 ui/gtk.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/ui/gtk.c b/ui/gtk.c
index a633d8934633..4d5ea8e6bb38 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -760,6 +760,13 @@ static gboolean gd_key_event(GtkWidget *widget, GdkEventKey *key, void *opaque)
     return TRUE;
 }
 
+static gboolean gd_event(GtkWidget *widget, GdkEvent *event, void *opaque)
+{
+    if (event->type == GDK_MOTION_NOTIFY)
+        return gd_motion_event(widget, &event->motion, opaque);
+    return FALSE;
+}
+
 /** Window Menu Actions **/
 
 static void gd_menu_pause(GtkMenuItem *item, void *opaque)
@@ -1254,8 +1261,8 @@ static void gd_connect_signals(GtkDisplayState *s)
     g_signal_connect(s->drawing_area, "expose-event",
                      G_CALLBACK(gd_expose_event), s);
 #endif
-    g_signal_connect(s->drawing_area, "motion-notify-event",
-                     G_CALLBACK(gd_motion_event), s);
+    g_signal_connect(s->drawing_area, "event",
+                     G_CALLBACK(gd_event), s);
     g_signal_connect(s->drawing_area, "button-press-event",
                      G_CALLBACK(gd_button_event), s);
     g_signal_connect(s->drawing_area, "button-release-event",
-- 
1.8.5.2

  reply	other threads:[~2014-02-13 11:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 11:15 [Qemu-devel] [PATCH 0/4] Fix relative pointer tracking on Gtk UI Takashi Iwai
2014-02-13 11:15 ` Takashi Iwai [this message]
2014-02-13 11:15 ` [Qemu-devel] [PATCH 2/4] gtk: Fix the relative pointer tracking mode Takashi Iwai
2014-02-13 11:15 ` [Qemu-devel] [PATCH 3/4] gtk: Remember the last grabbed pointer position Takashi Iwai
2014-02-13 11:15 ` [Qemu-devel] [PATCH 4/4] gtk: Add "Grab On Click" option Takashi Iwai
2014-04-01 20:34 ` [Qemu-devel] [PATCH 0/4] Fix relative pointer tracking on Gtk UI Cole Robinson
2014-04-02 12:29   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392290139-17250-2-git-send-email-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).