[Qemu-devel] [PATCH] spapr-vlan: flush queue whenever can_receive can go from false to true

[Qemu-devel] [PATCH] spapr-vlan: flush queue whenever can_receive can go from false to true

[Alexey Kardashevskiy]

When the guests adds buffers to receive queue, the network device
should flush its queue of pending packets. This is done with
qemu_flush_queued_packets.

This adds a call to qemu_flush_queued_packets() which wakes up the main
loop and let QEMU update the network device status which now is "can
receive". The patch basically does the same thing as e8b4c68 does.

Suggested-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 hw/net/spapr_llan.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c
index 72b0513..a7f00db 100644
--- a/hw/net/spapr_llan.c
+++ b/hw/net/spapr_llan.c
@@ -408,6 +408,8 @@ static target_ulong h_add_logical_lan_buffer(PowerPCCPU *cpu,
 
     dev->rx_bufs++;
 
+    qemu_flush_queued_packets(qemu_get_queue(dev->nic));
+
     DPRINTF("h_add_logical_lan_buffer():  Added buf  ptr=%d  rx_bufs=%d"
             " bd=0x%016llx\n", dev->add_buf_ptr, dev->rx_bufs,
             (unsigned long long)buf);
-- 
1.8.4.rc4

Re: [Qemu-devel] [PATCH] spapr-vlan: flush queue whenever can_receive can go from false to true

[Alexey Kardashevskiy]

On 02/14/2014 12:27 PM, Alexey Kardashevskiy wrote:
> When the guests adds buffers to receive queue, the network device
> should flush its queue of pending packets. This is done with
> qemu_flush_queued_packets.
> 
> This adds a call to qemu_flush_queued_packets() which wakes up the main
> loop and let QEMU update the network device status which now is "can
> receive". The patch basically does the same thing as e8b4c68 does.


Ping, anyone?


> Suggested-by: Max Filippov <jcmvbkbc@gmail.com>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  hw/net/spapr_llan.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/net/spapr_llan.c b/hw/net/spapr_llan.c
> index 72b0513..a7f00db 100644
> --- a/hw/net/spapr_llan.c
> +++ b/hw/net/spapr_llan.c
> @@ -408,6 +408,8 @@ static target_ulong h_add_logical_lan_buffer(PowerPCCPU *cpu,
>  
>      dev->rx_bufs++;
>  
> +    qemu_flush_queued_packets(qemu_get_queue(dev->nic));
> +
>      DPRINTF("h_add_logical_lan_buffer():  Added buf  ptr=%d  rx_bufs=%d"
>              " bd=0x%016llx\n", dev->add_buf_ptr, dev->rx_bufs,
>              (unsigned long long)buf);
> 


-- 
Alexey

Re: [Qemu-devel] [PATCH] spapr-vlan: flush queue whenever can_receive can go from false to true

[Alexander Graf]

On 21.02.2014, at 04:46, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:

> On 02/14/2014 12:27 PM, Alexey Kardashevskiy wrote:
>> When the guests adds buffers to receive queue, the network device
>> should flush its queue of pending packets. This is done with
>> qemu_flush_queued_packets.
>> 
>> This adds a call to qemu_flush_queued_packets() which wakes up the main
>> loop and let QEMU update the network device status which now is "can
>> receive". The patch basically does the same thing as e8b4c68 does.
> 
> 
> Ping, anyone?

Thanks, applied to ppc-next.


Alex