From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEVvN-0003Wk-SF for qemu-devel@nongnu.org; Fri, 14 Feb 2014 22:28:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WEVvI-0003IX-RS for qemu-devel@nongnu.org; Fri, 14 Feb 2014 22:28:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WEVvI-0003IM-Ht for qemu-devel@nongnu.org; Fri, 14 Feb 2014 22:28:12 -0500 From: Max Reitz Date: Sat, 15 Feb 2014 04:30:21 +0100 Message-Id: <1392435024-26694-6-git-send-email-mreitz@redhat.com> In-Reply-To: <1392435024-26694-1-git-send-email-mreitz@redhat.com> References: <1392435024-26694-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v3 5/8] block: Remove bdrv_new() from bdrv_file_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , =?UTF-8?q?Beno=C3=AEt=20Canet?= , Stefan Hajnoczi , Max Reitz Change bdrv_file_open() to take a simple pointer to an already existing BDS instead of an indirect one. The BDS will be created in bdrv_open() if necessary. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Reviewed-by: Kevin Wolf --- block.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/block.c b/block.c index a1adf93..7243630 100644 --- a/block.c +++ b/block.c @@ -953,10 +953,9 @@ free_and_fail: * after the call (even on failure), so if the caller intends to reuse the * dictionary, it needs to use QINCREF() before calling bdrv_file_open. */ -static int bdrv_file_open(BlockDriverState **pbs, const char *filename, +static int bdrv_file_open(BlockDriverState *bs, const char *filename, QDict *options, int flags, Error **errp) { - BlockDriverState *bs = NULL; BlockDriver *drv; const char *drvname; bool allow_protocol_prefix = false; @@ -968,7 +967,6 @@ static int bdrv_file_open(BlockDriverState **pbs, const char *filename, options = qdict_new(); } - bs = bdrv_new(""); bs->options = options; options = qdict_clone_shallow(options); @@ -1042,7 +1040,6 @@ static int bdrv_file_open(BlockDriverState **pbs, const char *filename, QDECREF(options); bs->growable = 1; - *pbs = bs; return 0; fail: @@ -1050,7 +1047,6 @@ fail: if (!bs->drv) { QDECREF(bs->options); } - bdrv_unref(bs); return ret; } @@ -1246,18 +1242,24 @@ int bdrv_open(BlockDriverState **pbs, const char *filename, return 0; } - if (flags & BDRV_O_PROTOCOL) { - assert(!drv); - return bdrv_file_open(pbs, filename, options, flags & ~BDRV_O_PROTOCOL, - errp); - } - if (*pbs) { bs = *pbs; } else { bs = bdrv_new(""); } + if (flags & BDRV_O_PROTOCOL) { + assert(!drv); + ret = bdrv_file_open(bs, filename, options, flags & ~BDRV_O_PROTOCOL, + errp); + if (ret && !*pbs) { + bdrv_unref(bs); + } else if (!ret) { + *pbs = bs; + } + return ret; + } + /* NULL means an empty set of options */ if (options == NULL) { options = qdict_new(); -- 1.8.5.4