From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFMIy-0007CV-Lo for qemu-devel@nongnu.org; Mon, 17 Feb 2014 06:24:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFMIq-00074Y-6h for qemu-devel@nongnu.org; Mon, 17 Feb 2014 06:24:08 -0500 Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:50756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFMIp-00074I-Vt for qemu-devel@nongnu.org; Mon, 17 Feb 2014 06:24:00 -0500 Received: by mail-qc0-f169.google.com with SMTP id w7so23873821qcr.0 for ; Mon, 17 Feb 2014 03:23:59 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 17 Feb 2014 12:23:44 +0100 Message-Id: <1392636226-26546-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1392636226-26546-1-git-send-email-pbonzini@redhat.com> References: <1392636226-26546-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] smbus: allow returning an error from reads List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.daerf@gmail.com, mst@redhat.com Signed-off-by: Paolo Bonzini --- hw/i2c/smbus.c | 6 +++--- include/hw/i2c/smbus.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/i2c/smbus.c b/hw/i2c/smbus.c index 25d2d04..a8931b7 100644 --- a/hw/i2c/smbus.c +++ b/hw/i2c/smbus.c @@ -214,7 +214,7 @@ void smbus_quick_command(i2c_bus *bus, uint8_t addr, int read) i2c_end_transfer(bus); } -uint8_t smbus_receive_byte(i2c_bus *bus, uint8_t addr) +int smbus_receive_byte(i2c_bus *bus, uint8_t addr) { uint8_t data; @@ -232,7 +232,7 @@ void smbus_send_byte(i2c_bus *bus, uint8_t addr, uint8_t data) i2c_end_transfer(bus); } -uint8_t smbus_read_byte(i2c_bus *bus, uint8_t addr, uint8_t command) +int smbus_read_byte(i2c_bus *bus, uint8_t addr, uint8_t command) { uint8_t data; i2c_start_transfer(bus, addr, 0); @@ -252,7 +252,7 @@ void smbus_write_byte(i2c_bus *bus, uint8_t addr, uint8_t command, uint8_t data) i2c_end_transfer(bus); } -uint16_t smbus_read_word(i2c_bus *bus, uint8_t addr, uint8_t command) +int smbus_read_word(i2c_bus *bus, uint8_t addr, uint8_t command) { uint16_t data; i2c_start_transfer(bus, addr, 0); diff --git a/include/hw/i2c/smbus.h b/include/hw/i2c/smbus.h index d764d75..4293733 100644 --- a/include/hw/i2c/smbus.h +++ b/include/hw/i2c/smbus.h @@ -67,11 +67,11 @@ struct SMBusDevice { /* Master device commands. */ void smbus_quick_command(i2c_bus *bus, uint8_t addr, int read); -uint8_t smbus_receive_byte(i2c_bus *bus, uint8_t addr); +int smbus_receive_byte(i2c_bus *bus, uint8_t addr); void smbus_send_byte(i2c_bus *bus, uint8_t addr, uint8_t data); -uint8_t smbus_read_byte(i2c_bus *bus, uint8_t addr, uint8_t command); +int smbus_read_byte(i2c_bus *bus, uint8_t addr, uint8_t command); void smbus_write_byte(i2c_bus *bus, uint8_t addr, uint8_t command, uint8_t data); -uint16_t smbus_read_word(i2c_bus *bus, uint8_t addr, uint8_t command); +int smbus_read_word(i2c_bus *bus, uint8_t addr, uint8_t command); void smbus_write_word(i2c_bus *bus, uint8_t addr, uint8_t command, uint16_t data); int smbus_read_block(i2c_bus *bus, uint8_t addr, uint8_t command, uint8_t *data); void smbus_write_block(i2c_bus *bus, uint8_t addr, uint8_t command, uint8_t *data, -- 1.8.5.3