From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
"Andreas Färber" <afaerber@suse.de>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL v2 08/49] nand: Don't use qdev_create() in nand_init()
Date: Mon, 17 Feb 2014 23:24:18 +0100 [thread overview]
Message-ID: <1392675899-21210-9-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1392675899-21210-1-git-send-email-afaerber@suse.de>
Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit
from Sysbus) changed the parent type of TYPE_NAND but continued to use
qdev_create(), which handled a NULL BusState as SysBus.
Use object_new() instead, and reuse the TYPE_NAND define while at it.
Reported-by: Markus Armbruster <armbru@redhat.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/block/nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/nand.c b/hw/block/nand.c
index a871ce0..6d7c804 100644
--- a/hw/block/nand.c
+++ b/hw/block/nand.c
@@ -632,7 +632,7 @@ DeviceState *nand_init(BlockDriverState *bdrv, int manf_id, int chip_id)
if (nand_flash_ids[chip_id].size == 0) {
hw_error("%s: Unsupported NAND chip ID.\n", __FUNCTION__);
}
- dev = qdev_create(NULL, "nand");
+ dev = DEVICE(object_new(TYPE_NAND));
qdev_prop_set_uint8(dev, "manufacturer_id", manf_id);
qdev_prop_set_uint8(dev, "chip_id", chip_id);
if (bdrv) {
--
1.8.4.5
next prev parent reply other threads:[~2014-02-17 22:25 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 22:24 [Qemu-devel] [PULL v2 00/49] QOM devices patch queue 2014-02-17 Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 01/49] qtest: don't report signals if qtest driver enabled Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 02/49] ppcemb-softmmu: Drop Mac and e500 emulation Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 03/49] target-ppc: Make ppc40x CPUs available in ppcemb Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 04/49] tests: Fix gcov paths for relocated device sources Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 05/49] qom-test: Run for all available machines Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 06/49] qom-test: Test shutdown in addition to startup Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 07/49] tests: Run qom-test for every architecture Andreas Färber
2014-02-17 22:24 ` Andreas Färber [this message]
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 09/49] i2c: Rename i2c_bus to I2CBus Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 10/49] pxa2xx: QOM'ify I2C slave Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 11/49] tosa: QOM'ify DAC Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 12/49] z2: QOM'ify AER915 Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 13/49] wm8750: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 14/49] ssd0303: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 15/49] max7310: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 16/49] lm832x: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 17/49] ds1338: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 18/49] twl92230: QOM'ify Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 19/49] i2c: Drop FROM_I2C_SLAVE() macro Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 20/49] tests: Add e1000 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 21/49] tests: Add vmxnet3 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 22/49] tests: Add rtl8139 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 23/49] tests: Add pcnet qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 24/49] tests: Add eepro100 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 25/49] tests: Add ne2000 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 26/49] tests: Add virtio-net qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 27/49] tests: Add tpci200 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 28/49] tests: Add ipoctal232 qtest Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 29/49] ipack: Convert to QOM realize Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 30/49] ipack: QOM parent field cleanup for IPackBus Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 31/49] ipack: QOM parent field cleanup for IPackDevice Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 32/49] ipoctal232: QOM parent field cleanup Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 33/49] ipack: Move IndustryPack out of hw/char/ Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 34/49] qtest: Don't segfault with invalid -qtest option Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 35/49] qapi: Add size parser to StringInputVisitor Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 36/49] qdev: Sizes are now parsed by StringInputVisitor Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 37/49] qdev: Remove legacy parsers for hex8/32/64 Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 38/49] qdev: Legacy properties are now read-only Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 39/49] qdev: Legacy properties are just strings Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 40/49] qdev: Inline qdev_prop_parse() Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 41/49] qapi: Add human mode to StringOutputVisitor Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 42/49] qdev: Use human mode in "info qtree" Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 43/49] qdev: Remove most legacy printers Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 44/49] qdev: Remove hex8/32/64 property types Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 45/49] block: Handle "rechs" and "large" translation options Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 46/49] qdev: Add enum property types to QAPI schema Andreas Färber
2014-02-17 22:30 ` Eric Blake
2014-02-18 8:05 ` Paolo Bonzini
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 47/49] qdev: Use QAPI type names for properties Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 48/49] qapi: Refine human printing of sizes Andreas Färber
2014-02-17 22:24 ` [Qemu-devel] [PULL v2 49/49] qtest: Include system headers before user headers Andreas Färber
2014-02-20 15:02 ` [Qemu-devel] [PULL v2 00/49] QOM devices patch queue 2014-02-17 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392675899-21210-9-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).