From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFZIN-0005GR-4s for qemu-devel@nongnu.org; Mon, 17 Feb 2014 20:16:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFZII-0007Zn-Bb for qemu-devel@nongnu.org; Mon, 17 Feb 2014 20:16:23 -0500 Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:44794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFZII-0007ZJ-7Y for qemu-devel@nongnu.org; Mon, 17 Feb 2014 20:16:18 -0500 Received: by mail-qc0-f178.google.com with SMTP id m20so24508694qcx.23 for ; Mon, 17 Feb 2014 17:16:17 -0800 (PST) Sender: Richard Henderson From: Richard Henderson Date: Mon, 17 Feb 2014 19:15:55 -0600 Message-Id: <1392686165-10706-6-git-send-email-rth@twiddle.net> In-Reply-To: <1392686165-10706-1-git-send-email-rth@twiddle.net> References: <1392686165-10706-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PULL 05/15] tcg/optimize: improve known-zero bits for 32-bit ops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno From: Aurelien Jarno The shl_i32 op might set some bits of the unused 32 high bits of the mask. Fix that by clearing the unused 32 high bits for all 32-bit ops except load/store which operate on tl values. Reviewed-by: Paolo Bonzini Signed-off-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/optimize.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 7838be2..1cf017a 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -783,6 +783,12 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, break; } + /* 32-bit ops (non 64-bit ops and non load/store ops) generate 32-bit + results */ + if (!(tcg_op_defs[op].flags & (TCG_OPF_CALL_CLOBBER | TCG_OPF_64BIT))) { + mask &= 0xffffffffu; + } + if (mask == 0) { assert(def->nb_oargs == 1); s->gen_opc_buf[op_index] = op_to_movi(op); -- 1.8.5.3