qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	Andreas Faerber <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH v2 0/3] qtest: avoid pidfile and QEMU process leaks
Date: Tue, 18 Feb 2014 15:54:46 +0100	[thread overview]
Message-ID: <1392735289-19484-1-git-send-email-stefanha@redhat.com> (raw)

v2:
 * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo]
 * Use sigemptyset() to avoid assumption about signal mask [Markus]
 * if (fd != -1) close(fd) is no longer necessary [Markus]

This series prevents the following qtest issues:

1. Leaking the pidfile if QEMU startup fails, as discovered by Andreas Färber.
2. Leaking the QEMU process when a test case aborts.

Applying this series should make buildbots and manual "make check" users have a
more pleasant and less leaky experience :).

Stefan Hajnoczi (3):
  qtest: drop unused child_pid field
  qtest: make QEMU our direct child process
  qtest: kill QEMU process on g_assert() failure

 tests/libqtest.c | 59 +++++++++++++++++++++++++-------------------------------
 1 file changed, 26 insertions(+), 33 deletions(-)

-- 
1.8.5.3

             reply	other threads:[~2014-02-18 14:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 14:54 Stefan Hajnoczi [this message]
2014-02-18 14:54 ` [Qemu-devel] [PATCH v2 1/3] qtest: drop unused child_pid field Stefan Hajnoczi
2014-02-18 14:54 ` [Qemu-devel] [PATCH v2 2/3] qtest: make QEMU our direct child process Stefan Hajnoczi
2014-02-18 14:54 ` [Qemu-devel] [PATCH v2 3/3] qtest: kill QEMU process on g_assert() failure Stefan Hajnoczi
2014-02-18 15:38   ` Paolo Bonzini
2014-02-18 16:32 ` [Qemu-devel] [PATCH v2 0/3] qtest: avoid pidfile and QEMU process leaks Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392735289-19484-1-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).