From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WFzRv-0008EL-0N for qemu-devel@nongnu.org; Wed, 19 Feb 2014 00:12:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WFzRo-0004yh-Ec for qemu-devel@nongnu.org; Wed, 19 Feb 2014 00:11:58 -0500 From: Stefan Weil Date: Wed, 19 Feb 2014 06:11:44 +0100 Message-Id: <1392786705-9730-2-git-send-email-sw@weilnetz.de> In-Reply-To: <1392786705-9730-1-git-send-email-sw@weilnetz.de> References: <1392786705-9730-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH 1/2] bswap: Modify prototype of stb_p (avoid type conversions) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: Stefan Weil , Laszlo Ersek , qemu-devel@nongnu.org The function uses an uint8_t value, so show this in the function prototype. Non-optimizing compilers will avoid unnecessary type conversions from (u)int8_t to int and back to uint8_t when generating calls of this inline function. stw_p, stl_p and stq_p already use similar prototypes. Signed-off-by: Stefan Weil --- include/qemu/bswap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h index 437b8e0..0cc11a5 100644 --- a/include/qemu/bswap.h +++ b/include/qemu/bswap.h @@ -228,7 +228,7 @@ static inline int ldsb_p(const void *ptr) return *(int8_t *)ptr; } -static inline void stb_p(void *ptr, int v) +static inline void stb_p(void *ptr, uint8_t v) { *(uint8_t *)ptr = v; } -- 1.7.10.4