Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

[Stefan Hajnoczi]

Sorry, I forgot to CC qemu-devel on this:

On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> Hi,
> The mingw32 build is failing as follows:
>
> In file included from qga/vss-win32.c:17:
> ./qga/vss-win32/requester.h:31: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 'requester_init'
> ./qga/vss-win32/requester.h:32: error: expected '=', ',', ';', 'asm'
> or '__attribute__' before 'requester_deinit'
>
> http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/783
>
> It's important that we keep the QEMU buildbot working so that compile
> errors and test failures are caught before release.  The buildbot is
> currently in bad shape (lots of failures), so I am sending out emails
> requesting help.
>
> I'm emailing you since you are familiar with the code and might be
> able to fix this issue.  Do you have time to investigate?
>
> If not, please CC folks who can help.
>
> Thanks,
> Stefan

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

[Tomoki Sekiyama]

Hi Stefan,


On 11/20/13 4:16 , "Stefan Hajnoczi" <stefanha@gmail.com> wrote:
>Sorry, I forgot to CC qemu-devel on this:
>
>On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi <stefanha@gmail.com>
>wrote:
>> Hi,
>> The mingw32 build is failing as follows:
>>
>> In file included from qga/vss-win32.c:17:
>> ./qga/vss-win32/requester.h:31: error: expected '=', ',', ';', 'asm'
>> or '__attribute__' before 'requester_init'
>> ./qga/vss-win32/requester.h:32: error: expected '=', ',', ';', 'asm'
>> or '__attribute__' before 'requester_deinit'
>>
>> http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/783
>>
>> It's important that we keep the QEMU buildbot working so that compile
>> errors and test failures are caught before release.  The buildbot is
>> currently in bad shape (lots of failures), so I am sending out emails
>> requesting help.
>>
>> I'm emailing you since you are familiar with the code and might be
>> able to fix this issue.  Do you have time to investigate?
>>
>> If not, please CC folks who can help.
>>
>> Thanks,
>> Stefan

Thanks for letting me know this.

I'm investigating the issue, but it looks already fixed in the code in
the upstream git tree, by commit ba1c293109:
    "qga: Fix compilation for old version of MinGW"

Could you try this fix?

Thanks,

Tomoki Sekiyama

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

[Stefan Weil]

Am 20.11.2013 18:40, schrieb Tomoki Sekiyama:
> Hi Stefan,
>
>
> On 11/20/13 4:16 , "Stefan Hajnoczi" <stefanha@gmail.com> wrote:
>> Sorry, I forgot to CC qemu-devel on this:
>>
>> On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi <stefanha@gmail.com>
>> wrote:
>>> Hi,
>>> The mingw32 build is failing as follows:
>>>
>>> In file included from qga/vss-win32.c:17:
>>> ./qga/vss-win32/requester.h:31: error: expected '=', ',', ';', 'asm'
>>> or '__attribute__' before 'requester_init'
>>> ./qga/vss-win32/requester.h:32: error: expected '=', ',', ';', 'asm'
>>> or '__attribute__' before 'requester_deinit'
>>>
>>> http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/783
>>>
>>> It's important that we keep the QEMU buildbot working so that compile
>>> errors and test failures are caught before release.  The buildbot is
>>> currently in bad shape (lots of failures), so I am sending out emails
>>> requesting help.
>>>
>>> I'm emailing you since you are familiar with the code and might be
>>> able to fix this issue.  Do you have time to investigate?
>>>
>>> If not, please CC folks who can help.
>>>
>>> Thanks,
>>> Stefan
> Thanks for letting me know this.
>
> I'm investigating the issue, but it looks already fixed in the code in
> the upstream git tree, by commit ba1c293109:
>     "qga: Fix compilation for old version of MinGW"
>
> Could you try this fix?
>
> Thanks,
>
> Tomoki Sekiyama
>

That's correct, it should be fixed now and we'll see the result
automatically in the next buildbot run.

>From Anthony's commit time, I had expected that it would already be
fixed today (in the last build), but obviously the buildbot does not
pull from qemu.org (or qemu-project.org) - otherwise it would have
pulled the fix...

Regards,
Stefan W.

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

[Stefan Hajnoczi]

On Wed, Nov 20, 2013 at 05:40:15PM +0000, Tomoki Sekiyama wrote:
> On 11/20/13 4:16 , "Stefan Hajnoczi" <stefanha@gmail.com> wrote:
> >Sorry, I forgot to CC qemu-devel on this:
> >
> >On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi <stefanha@gmail.com>
> >wrote:
> >> Hi,
> >> The mingw32 build is failing as follows:
> >>
> >> In file included from qga/vss-win32.c:17:
> >> ./qga/vss-win32/requester.h:31: error: expected '=', ',', ';', 'asm'
> >> or '__attribute__' before 'requester_init'
> >> ./qga/vss-win32/requester.h:32: error: expected '=', ',', ';', 'asm'
> >> or '__attribute__' before 'requester_deinit'
> >>
> >> http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/783
> >>
> >> It's important that we keep the QEMU buildbot working so that compile
> >> errors and test failures are caught before release.  The buildbot is
> >> currently in bad shape (lots of failures), so I am sending out emails
> >> requesting help.
> >>
> >> I'm emailing you since you are familiar with the code and might be
> >> able to fix this issue.  Do you have time to investigate?
> >>
> >> If not, please CC folks who can help.
> >>
> >> Thanks,
> >> Stefan
> 
> Thanks for letting me know this.
> 
> I'm investigating the issue, but it looks already fixed in the code in
> the upstream git tree, by commit ba1c293109:
>     "qga: Fix compilation for old version of MinGW"
> 
> Could you try this fix?

Excellent, thanks!  The latest buildbot has compiled successfully:
http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/784

It's now hitting a make check failure unrelated to VSS.

Thanks,
Stefan

Re: [Qemu-devel] Buildbot failure: MinGW (was: qga/vss-win32/requester.h compile error)

[Stefan Weil]

Am 21.11.2013 09:40, schrieb Stefan Hajnoczi:
> Excellent, thanks!  The latest buildbot has compiled successfully:
> http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/784
>
> It's now hitting a make check failure unrelated to VSS.
>
> Thanks,
> Stefan

'make check' for MinGW cross builds needs an installation of wine to run
the resulting exe files.

I also had to fix tests/Makefile to exclude some POSIX-only tests and to
makesome smaller code fixes.
Now I can run 'make check' for MinGW on a Linux host.

Patches will follow after QEMU 1.7 - maybe you can prepare the buildbot
with wine.

Regards,
Stefan

Re: [Qemu-devel] Buildbot failure: MinGW (was: qga/vss-win32/requester.h compile error)

[Stefan Hajnoczi]

On Fri, Nov 22, 2013 at 07:56:12AM +0100, Stefan Weil wrote:
> Am 21.11.2013 09:40, schrieb Stefan Hajnoczi:
> > Excellent, thanks!  The latest buildbot has compiled successfully:
> > http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/784
> >
> > It's now hitting a make check failure unrelated to VSS.
> >
> > Thanks,
> > Stefan
> 
> 'make check' for MinGW cross builds needs an installation of wine to run
> the resulting exe files.
> 
> I also had to fix tests/Makefile to exclude some POSIX-only tests and to
> makesome smaller code fixes.
> Now I can run 'make check' for MinGW on a Linux host.
> 
> Patches will follow after QEMU 1.7 - maybe you can prepare the buildbot
> with wine.

The mingw build runs on Gerd's buildslave.  He would need to install
wine on the kraxel_rhel61 buildslave.

Stefan

Re: [Qemu-devel] Buildbot failure: MinGW (was: qga/vss-win32/requester.h compile error)

[Gerd Hoffmann]

  Hi,

> > 'make check' for MinGW cross builds needs an installation of wine to run
> > the resulting exe files.

I don't think it is a good idea to run tests for cross builds by
default.

cheers,
  Gerd

Re: [Qemu-devel] Buildbot failure: MinGW

[Stefan Weil]

Am 22.11.2013 13:51, schrieb Gerd Hoffmann:
>   Hi,
>
>>> 'make check' for MinGW cross builds needs an installation of wine to run
>>> the resulting exe files.
> I don't think it is a good idea to run tests for cross builds by
> default.
>
> cheers,
>   Gerd

Why not? In this case (MinGW), setting up cross builds is rather easy,
and also testing them with Wine seems to be easy and successful: it
detects the current coroutine problem, for example.

If we don't want tests for the MinGW cross build, the buildbot
configuration should to be changed - otherwise we'll always see "failed
test" instead of "build successful" for MinGW.

Cheers,
Stefan

Re: [Qemu-devel] Buildbot failure: MinGW

[Gerd Hoffmann]

On So, 2013-11-24 at 11:21 +0100, Stefan Weil wrote:
> Am 22.11.2013 13:51, schrieb Gerd Hoffmann:
> >   Hi,
> >
> >>> 'make check' for MinGW cross builds needs an installation of wine to run
> >>> the resulting exe files.
> > I don't think it is a good idea to run tests for cross builds by
> > default.
> >
> > cheers,
> >   Gerd
> 
> Why not?

Because making them run requires extra setup effort on the host which
you can't assume is there.

> In this case (MinGW), setting up cross builds is rather easy,
> and also testing them with Wine seems to be easy and successful: it
> detects the current coroutine problem, for example.

It makes sense to be able to run those checks on wine, no question.  But
simply assuming wine is there and run them unconditionally isn't a good
idea IMHO.

I think we should either have "make check" autodetect whenever wine is
present, or have a separate make target for tests which require wine
which is not run by default.

cheers,
  Gerd

Re: [Qemu-devel] Buildbot failure: MinGW

[Stefan Weil]

Hi Gerd, hi Stefan,

we now need a C++ compiler on the buildbots. Currently, it's missing for
MinGW:

/bin/sh: i686-pc-mingw32-g++: command not found

Cheers
Stefan

Re: [Qemu-devel] Buildbot failure: MinGW

[Gerd Hoffmann]

On Mi, 2014-02-19 at 05:27 +0100, Stefan Weil wrote:
> Hi Gerd, hi Stefan,
> 
> we now need a C++ compiler on the buildbots. Currently, it's missing for
> MinGW:
> 
> /bin/sh: i686-pc-mingw32-g++: command not found

Installed.

cheers,
  Gerd

Re: [Qemu-devel] Buildbot failure: MinGW

[Peter Maydell]

On 19 February 2014 04:27, Stefan Weil <sw@weilnetz.de> wrote:
> Hi Gerd, hi Stefan,
>
> we now need a C++ compiler on the buildbots. Currently, it's missing for
> MinGW:
>
> /bin/sh: i686-pc-mingw32-g++: command not found

Don't we successfully fall back to "don't build C++ things" if
configure doesn't detect the C++ compiler?

thanks
-- PMM

Re: [Qemu-devel] Buildbot failure: MinGW

[Thomas Huth]

On Wed, 19 Feb 2014 11:53:09 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:

> On 19 February 2014 04:27, Stefan Weil <sw@weilnetz.de> wrote:
> > Hi Gerd, hi Stefan,
> >
> > we now need a C++ compiler on the buildbots. Currently, it's missing for
> > MinGW:
> >
> > /bin/sh: i686-pc-mingw32-g++: command not found
> 
> Don't we successfully fall back to "don't build C++ things" if
> configure doesn't detect the C++ compiler?

I recently had a similar problem compiling QEMU on a freshly installed
system, where I only had a normal C compiler, but no C++ installed yet.

In rules.mak, you can find these lines:

 # If we have a CXX we might have some C++ objects, in which case we
 # must link with the C++ compiler, not the plain C compiler.
 LINKPROG = $(or $(CXX),$(CC))

So that's ok, it sets LINKPROG to the c++ compiler if the variable is
set, and to the C compiler if not.

But now have a look at the configure script:

 if test -z "${CXX}${cross_prefix}"; then
   cxx="c++"
 else
   cxx="${CXX-${cross_prefix}g++}"
 fi

 [...]

 echo "CXX=$cxx" >> $config_host_mak

That seems to always set the CXX variable! I think the above
if-statement is wrong, it should set cxx only if the c++ program is
really available.

 Thomas

Re: [Qemu-devel] Buildbot failure: MinGW

[Peter Maydell]

On 19 February 2014 12:18, Thomas Huth <thuth@linux.vnet.ibm.com> wrote:
> I recently had a similar problem compiling QEMU on a freshly installed
> system, where I only had a normal C compiler, but no C++ installed yet.
>
> In rules.mak, you can find these lines:
>
>  # If we have a CXX we might have some C++ objects, in which case we
>  # must link with the C++ compiler, not the plain C compiler.
>  LINKPROG = $(or $(CXX),$(CC))
>
> So that's ok, it sets LINKPROG to the c++ compiler if the variable is
> set, and to the C compiler if not.
>
> But now have a look at the configure script:
>
>  if test -z "${CXX}${cross_prefix}"; then
>    cxx="c++"
>  else
>    cxx="${CXX-${cross_prefix}g++}"
>  fi
>
>  [...]
>
>  echo "CXX=$cxx" >> $config_host_mak
>
> That seems to always set the CXX variable! I think the above
> if-statement is wrong, it should set cxx only if the c++ program is
> really available.

Yes, you're right. Certainly my intention with the vixl changes
was to only build with C++ if a C++ compiler was present; I
must have misread this bit of configure. I'll put together a patch.

thanks
-- PMM