From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG8UD-00061h-Hd for qemu-devel@nongnu.org; Wed, 19 Feb 2014 09:51:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG8U8-0003Ju-PY for qemu-devel@nongnu.org; Wed, 19 Feb 2014 09:50:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:26612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG8U8-0003Jp-HJ for qemu-devel@nongnu.org; Wed, 19 Feb 2014 09:50:52 -0500 From: Stefan Hajnoczi Date: Wed, 19 Feb 2014 15:50:42 +0100 Message-Id: <1392821445-4587-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 0/3] qtest: avoid pidfile and QEMU process leaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori Reviewed by Paolo and Markus. Here is the pull request. v2: * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo= ] * Use sigemptyset() to avoid assumption about signal mask [Markus] * if (fd !=3D -1) close(fd) is no longer necessary [Markus] This series prevents the following qtest issues: 1. Leaking the pidfile if QEMU startup fails, as discovered by Andreas F=C3= =A4rber. 2. Leaking the QEMU process when a test case aborts. Applying this series should make buildbots and manual "make check" users = have a more pleasant and less leaky experience :). The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e8d= bb: Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +0000) are available in the git repository at: git://github.com/stefanha/qemu.git tags/qtest-monitor-process-pull-requ= est for you to fetch changes up to b15d422a23a3e4cf1b4195af209211eccdb88d51: qtest: kill QEMU process on g_assert() failure (2014-02-19 15:45:51 +01= 00) ---------------------------------------------------------------- qtest resource cleanup pull request ---------------------------------------------------------------- Stefan Hajnoczi (3): qtest: drop unused child_pid field qtest: make QEMU our direct child process qtest: kill QEMU process on g_assert() failure tests/libqtest.c | 59 +++++++++++++++++++++++++-------------------------= ------ 1 file changed, 26 insertions(+), 33 deletions(-) --=20 1.8.5.3