qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH 0/7] qemu-img: Fix handling of multiply specified options
Date: Wed, 19 Feb 2014 16:12:51 +0100	[thread overview]
Message-ID: <1392822778-4823-1-git-send-email-kwolf@redhat.com> (raw)

If you specify the same option more than once (e.g. -o cluster_size=4k
-o lazy_refcounts=on), qemu-img silently ignores all but the last one. This
series fixes it to either consider all options or to give an error message.

Boolean option can still be given more than once as they aren't problematic
in this respect (ten times -q is still quiet).

Kevin Wolf (7):
  qemu-img create: Detect options specified more than once
  qemu-img convert: Detect options specified more than once
  qemu-img amend: Detect options specified more than once
  qemu-img: Detect options specified more than once
  qemu-img create: Support multiple -o options
  qemu-img convert: Support multiple -o options
  qemu-img amend: Support multiple -o options

 qemu-img.c | 198 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 177 insertions(+), 21 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2014-02-19 15:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 15:12 Kevin Wolf [this message]
2014-02-19 15:12 ` [Qemu-devel] [PATCH 1/7] qemu-img create: Detect options specified more than once Kevin Wolf
2014-02-19 16:05   ` Fam Zheng
2014-02-19 16:38   ` Eric Blake
2014-02-19 15:12 ` [Qemu-devel] [PATCH 2/7] qemu-img convert: " Kevin Wolf
2014-02-19 15:12 ` [Qemu-devel] [PATCH 3/7] qemu-img amend: " Kevin Wolf
2014-02-19 15:12 ` [Qemu-devel] [PATCH 4/7] qemu-img: " Kevin Wolf
2014-02-19 15:12 ` [Qemu-devel] [PATCH 5/7] qemu-img create: Support multiple -o options Kevin Wolf
2014-02-19 16:18   ` Fam Zheng
2014-02-19 16:46   ` Eric Blake
2014-02-19 15:12 ` [Qemu-devel] [PATCH 6/7] qemu-img convert: " Kevin Wolf
2014-02-19 15:12 ` [Qemu-devel] [PATCH 7/7] qemu-img amend: " Kevin Wolf
2014-02-20  7:18 ` [Qemu-devel] [PATCH 0/7] qemu-img: Fix handling of multiply specified options Markus Armbruster
2014-02-20  9:03   ` Kevin Wolf
2014-02-20  9:48     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392822778-4823-1-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).