From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG9iA-0001ON-Kb for qemu-devel@nongnu.org; Wed, 19 Feb 2014 11:09:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG9i5-0004ea-LY for qemu-devel@nongnu.org; Wed, 19 Feb 2014 11:09:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG9i5-0004d4-DP for qemu-devel@nongnu.org; Wed, 19 Feb 2014 11:09:21 -0500 Message-ID: <1392826156.15608.521.camel@ul30vt.home> From: Alex Williamson Date: Wed, 19 Feb 2014 09:09:16 -0700 In-Reply-To: <20140217145138.GJ29329@ERROL.INI.CMU.EDU> References: <1392647087-23020-1-git-send-email-mst@redhat.com> <1392647087-23020-2-git-send-email-mst@redhat.com> <20140217145138.GJ29329@ERROL.INI.CMU.EDU> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 1/5] acpi-build: append description for non-hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" Cc: Peter Maydell , qemu-devel@nongnu.org, Anthony Liguori , "Michael S. Tsirkin" On Mon, 2014-02-17 at 09:51 -0500, Gabriel L. Somlo wrote: > Michael, > > On Mon, Feb 17, 2014 at 04:25:26PM +0200, Michael S. Tsirkin wrote: > > As reported in > > http://article.gmane.org/gmane.comp.emulators.qemu/253987 > > Mac OSX actually requires describing all occupied slots > > in ACPI - even if hotplug isn't enabled. > > > > I didn't expect this so I dropped description of all > > non hotpluggable slots from ACPI. > > As a result: before > > commit 99fd437dee468609de8218f0eb3b16621fb6a9c9 (enable > > hotplug for pci bridges), PCI cards show up in the "device tree" of OS X > > (System Information). E.g., on MountainLion users have: > > > > ... > > > > Ethernet still works, but it's not showing up on the PCI bus, and it > > no longer thinks it's plugged in to slot #2, as it used to before the > > change. > > > > To fix, append description for all occupied non hotpluggable PCI slots. > > > > One need to be careful when doing this: VGA and ISA device were already > > described, so we need to drop description from DSDT. > > > > Reported-by: Gabriel L. Somlo > > Signed-off-by: Michael S. Tsirkin > > --- > > ... > > With this latest version of your patch, I crash during OS X boot with > "unable to find driver for this platform:\"ACPI\".\n"@/SourceCache/xnu/xnu-2050.48.12/iokit/Kernel/IOPlatformExpert.cpp:1514" Also getting a STOP 0xA5 BSOD for win7x64 guest with this. Thanks, Alex