From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alex Williamson <alex.williamson@redhat.com>,
Michael Tsirkin <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 1/2 v2] pci: change default value of rom_bar to 2
Date: Wed, 19 Feb 2014 15:20:54 -0500 [thread overview]
Message-ID: <1392841255-22741-2-git-send-email-bsd@redhat.com> (raw)
In-Reply-To: <1392841255-22741-1-git-send-email-bsd@redhat.com>
The following patch depends on the value of rom_bar to
determine rom blacklist behavior. Existing code shouldn't
be affected by changing the default value of rom_bar since
all relevant decisions only rely on whether rom_bar is zero
or non-zero.
Signed-off-by: Bandan Das <bsd@redhat.com>
---
hw/pci/pci.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 4e0701d..12c3e27 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -53,7 +53,12 @@ static void pci_bus_finalize(Object *obj);
static Property pci_props[] = {
DEFINE_PROP_PCI_DEVFN("addr", PCIDevice, devfn, -1),
DEFINE_PROP_STRING("romfile", PCIDevice, romfile),
- DEFINE_PROP_UINT32("rombar", PCIDevice, rom_bar, 1),
+ /*
+ * 0 = disable
+ * 1 = user requested on, force loading even if rom blacklisted
+ * 2 = enabled but disables loading of blacklisted roms (default)
+ */
+ DEFINE_PROP_UINT32("rombar", PCIDevice, rom_bar, 2),
DEFINE_PROP_BIT("multifunction", PCIDevice, cap_present,
QEMU_PCI_CAP_MULTIFUNCTION_BITNR, false),
DEFINE_PROP_BIT("command_serr_enable", PCIDevice, cap_present,
--
1.8.3.1
next prev parent reply other threads:[~2014-02-19 20:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 20:20 [Qemu-devel] [PATCH 0/2 v2] vfio: blacklist loading of unstable roms Bandan Das
2014-02-19 20:20 ` Bandan Das [this message]
2014-02-19 20:36 ` [Qemu-devel] [PATCH 1/2 v2] pci: change default value of rom_bar to 2 Alex Williamson
2014-02-19 20:43 ` Bandan Das
2014-02-20 8:13 ` Michael S. Tsirkin
2014-02-20 8:12 ` Michael S. Tsirkin
2014-02-20 17:22 ` Bandan Das
2014-02-22 23:28 ` Alex Williamson
2014-02-23 6:32 ` Michael S. Tsirkin
2014-02-23 14:18 ` Alex Williamson
2014-02-24 0:31 ` Michael S. Tsirkin
2014-02-24 1:32 ` Bandan Das
2014-02-24 2:56 ` Alex Williamson
2014-02-19 20:20 ` [Qemu-devel] [PATCH 2/2 v2] vfio: blacklist loading of unstable roms Bandan Das
2014-02-19 20:58 ` Alex Williamson
2014-02-20 17:27 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392841255-22741-2-git-send-email-bsd@redhat.com \
--to=bsd@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).