From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGDfu-0001Tn-Qu for qemu-devel@nongnu.org; Wed, 19 Feb 2014 15:23:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGDfo-0008Eu-Rv for qemu-devel@nongnu.org; Wed, 19 Feb 2014 15:23:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGDfo-0008Eo-JG for qemu-devel@nongnu.org; Wed, 19 Feb 2014 15:23:16 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1JKNF98025642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 19 Feb 2014 15:23:15 -0500 From: Bandan Das Date: Wed, 19 Feb 2014 15:20:54 -0500 Message-Id: <1392841255-22741-2-git-send-email-bsd@redhat.com> In-Reply-To: <1392841255-22741-1-git-send-email-bsd@redhat.com> References: <1392841255-22741-1-git-send-email-bsd@redhat.com> Subject: [Qemu-devel] [PATCH 1/2 v2] pci: change default value of rom_bar to 2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Alex Williamson , Michael Tsirkin The following patch depends on the value of rom_bar to determine rom blacklist behavior. Existing code shouldn't be affected by changing the default value of rom_bar since all relevant decisions only rely on whether rom_bar is zero or non-zero. Signed-off-by: Bandan Das --- hw/pci/pci.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 4e0701d..12c3e27 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -53,7 +53,12 @@ static void pci_bus_finalize(Object *obj); static Property pci_props[] = { DEFINE_PROP_PCI_DEVFN("addr", PCIDevice, devfn, -1), DEFINE_PROP_STRING("romfile", PCIDevice, romfile), - DEFINE_PROP_UINT32("rombar", PCIDevice, rom_bar, 1), + /* + * 0 = disable + * 1 = user requested on, force loading even if rom blacklisted + * 2 = enabled but disables loading of blacklisted roms (default) + */ + DEFINE_PROP_UINT32("rombar", PCIDevice, rom_bar, 2), DEFINE_PROP_BIT("multifunction", PCIDevice, cap_present, QEMU_PCI_CAP_MULTIFUNCTION_BITNR, false), DEFINE_PROP_BIT("command_serr_enable", PCIDevice, cap_present, -- 1.8.3.1