qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <mlureau@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: marcandre lureau <marcandre.lureau@redhat.com>,
	claudio fontana <claudio.fontana@huawei.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.5 3/5] tests/ivshmem-test: Supply missing initializer in get_device()
Date: Tue, 24 Nov 2015 12:16:25 -0500 (EST)	[thread overview]
Message-ID: <1392859900.16565560.1448385385696.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1448384789-14830-4-git-send-email-armbru@redhat.com>



----- Original Message -----
> If the device isn't found, the assertion uses dev without
> initialization.  Fix that.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

my bad :)

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  tests/ivshmem-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c
> index f1793ba..8f1a849 100644
> --- a/tests/ivshmem-test.c
> +++ b/tests/ivshmem-test.c
> @@ -40,6 +40,7 @@ static QPCIDevice *get_device(void)
>      QPCIBus *pcibus;
>  
>      pcibus = qpci_init_pc();
> +    dev = NULL;
>      qpci_device_foreach(pcibus, 0x1af4, 0x1110, save_fn, &dev);
>      g_assert(dev != NULL);
>  
> --
> 2.4.3
> 
> 

  reply	other threads:[~2015-11-24 17:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 17:06 [Qemu-devel] [PATCH for-2.5 0/5] ivshmem: Last minute changes Markus Armbruster
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 1/5] qemu-doc: Fix ivshmem example markup Markus Armbruster
2015-11-24 17:12   ` Marc-André Lureau
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 2/5] qemu-doc: Fix ivshmem usage example with shm= Markus Armbruster
2015-11-24 17:14   ` Marc-André Lureau
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 3/5] tests/ivshmem-test: Supply missing initializer in get_device() Markus Armbruster
2015-11-24 17:16   ` Marc-André Lureau [this message]
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 4/5] ivshmem: Mark questionable socket type test FIXME Markus Armbruster
2015-11-24 17:17   ` Marc-André Lureau
2015-11-24 17:29     ` Markus Armbruster
2015-11-24 17:42       ` Marc-André Lureau
2015-11-24 18:53         ` Markus Armbruster
2015-11-24 19:52           ` Marc-André Lureau
2015-11-25  8:42             ` Markus Armbruster
2015-11-25  8:46               ` Marc-André Lureau
2015-11-25  9:18                 ` Markus Armbruster
2015-11-24 17:06 ` [Qemu-devel] [PATCH for-2.5 5/5] ivshmem: Rename property memdev to x-memdev for 2.5 Markus Armbruster
2015-11-24 17:20   ` Marc-André Lureau
2015-11-24 17:28   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392859900.16565560.1448385385696.JavaMail.zimbra@redhat.com \
    --to=mlureau@redhat.com \
    --cc=armbru@redhat.com \
    --cc=claudio.fontana@huawei.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).