Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

[Gerd Hoffmann <kraxel@redhat.com>]

On Mi, 2014-02-19 at 15:40 -0500, Gabriel L. Somlo wrote:
> On Wed, Feb 19, 2014 at 10:59:34AM +0100, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > However, when I compare unmodified SMBIOS against what I get when
> > > supplying the patched binary table via command line, I get this:
> > 
> > As Laszlo already sayed: one table per file.
> 
> So I gave up on that relatively quickly, as there's no easy and
> convenient way to "harvest" a binary of just one table type from
> a host that works the way I want it... :(

"dmidecode --type 2" ?

> Besides, I think smbios_maybe_add_str() looks wrong: It looks like
> it's trying to paste a string into a given type structure at the
> field offset, but I think the field should actually be an *index*
> into a concatenated set of zero-terminated strings tacked on to the
> end of the type struct (see load_str_field_* macros in
> seabios src/fw/smbios.c).
> 
> What am I missing ?

smbios_maybe_add_str puts a string into the "transfer field to seabios"
list, and seabios generates the table using it.  When generating the
complete table in qemu it indeed doesn't fulfill the purpose ...

cheers,
  Gerd