qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing
@ 2014-02-20 15:37 alex.bennee
  2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 1/4] .travis.yml: add a new build target with non-core devlibs alex.bennee
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: alex.bennee @ 2014-02-20 15:37 UTC (permalink / raw)
  To: qemu-devel

From: Alex Bennée <alex.bennee@linaro.org>

Hi,

I've now enabled Travis testing on the "official" QEMU GitHub mirror.

Of the following patches two expand the testing, one is a cosmetic
whitespace fix and the final one enabled IRC notification when the
build fails. This is potentially controversial but on balance I think
it would be worth while letting #qemu know as soon as master breaks.
If lots of people start enabling Travis on there own repos then maybe
we would reconsider the notification idea.

As it is build failures should automatically email the author of
${HEAD} as well as the owner of the repo.

There has been interest expressed in running tests on all PULL
requests. One option would be to have some sort of bot (via
patchwork?) push PULL request heads to another GitHub mirror
(qemu-pull-requests.git?) to trigger builds.


Alex Bennée (4):
  .travis.yml: add a new build target with non-core devlibs
  .travis.yml: re-enable lttng user space trace test
  .travis.yml: trivial whitespace fixup
  .travis.yml: add IRC notifications for build failures

 .travis.yml | 53 +++++++++++++++++++++++++++++++----------------------
 1 file changed, 31 insertions(+), 22 deletions(-)


Cheers,

--
Alex Bennée
QEMU/KVM Hacker for Linaro

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH v1 1/4] .travis.yml: add a new build target with non-core devlibs
  2014-02-20 15:37 [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing alex.bennee
@ 2014-02-20 15:37 ` alex.bennee
  2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 2/4] .travis.yml: re-enable lttng user space trace test alex.bennee
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: alex.bennee @ 2014-02-20 15:37 UTC (permalink / raw)
  To: qemu-devel

From: Alex Bennée <alex.bennee@linaro.org>

The current builds don't include all the features which are
auto-detected and then disabled when the appropriate test packages don't
exist. I've added another target that enables all known additional
packages for increased coverage. I didn't add it to the core package
list to reduce build time.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

diff --git a/.travis.yml b/.travis.yml
index c7ff4da..286cf62 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -46,6 +46,10 @@ matrix:
     - env: TARGETS=i386-softmmu,x86_64-softmmu
            EXTRA_CONFIG="--enable-debug --enable-tcg-interpreter"
       compiler: gcc
+    # All the extra -dev packages
+    - env: TARGETS=i386-softmmu,x86_64-softmmu
+           EXTRA_PKGS="libaio-dev libcap-ng-dev libattr1-dev libbrlapi-dev uuid-dev libusb-1.0.0-dev"
+      compiler: gcc
     # Currently configure doesn't force --disable-pie
     - env: TARGETS=i386-softmmu,x86_64-softmmu
            EXTRA_CONFIG="--enable-gprof --enable-gcov --disable-pie"
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH v1 2/4] .travis.yml: re-enable lttng user space trace test
  2014-02-20 15:37 [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing alex.bennee
  2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 1/4] .travis.yml: add a new build target with non-core devlibs alex.bennee
@ 2014-02-20 15:37 ` alex.bennee
  2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 3/4] .travis.yml: trivial whitespace fixup alex.bennee
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: alex.bennee @ 2014-02-20 15:37 UTC (permalink / raw)
  To: qemu-devel

From: Alex Bennée <alex.bennee@linaro.org>

This build was disabled while the lttng tracing was broken. Stefan has
recently submitted a pull request with it re-enabled.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

diff --git a/.travis.yml b/.travis.yml
index 286cf62..1d78421 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -69,8 +69,7 @@ matrix:
            EXTRA_CONFIG="--enable-trace-backend=ftrace"
            TEST_CMD=""
       compiler: gcc
-    # This disabled make check for the ftrace backend which needs more setting up
-    # Currently broken on 12.04 due to mis-packaged liburcu and changed API, will be pulled.
-    #- env: TARGETS=i386-softmmu,x86_64-softmmu
-    #       EXTRA_PKGS="liblttng-ust-dev liburcu-dev"
-    #       EXTRA_CONFIG="--enable-trace-backend=ust"
+    - env: TARGETS=i386-softmmu,x86_64-softmmu
+          EXTRA_PKGS="liblttng-ust-dev liburcu-dev"
+          EXTRA_CONFIG="--enable-trace-backend=ust"
+      compiler: gcc
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH v1 3/4] .travis.yml: trivial whitespace fixup
  2014-02-20 15:37 [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing alex.bennee
  2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 1/4] .travis.yml: add a new build target with non-core devlibs alex.bennee
  2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 2/4] .travis.yml: re-enable lttng user space trace test alex.bennee
@ 2014-02-20 15:37 ` alex.bennee
  2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 4/4] .travis.yml: add IRC notifications for build failures alex.bennee
  2014-02-24 15:41 ` [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing Stefan Hajnoczi
  4 siblings, 0 replies; 6+ messages in thread
From: alex.bennee @ 2014-02-20 15:37 UTC (permalink / raw)
  To: qemu-devel

From: Alex Bennée <alex.bennee@linaro.org>

Purely cosmetic but satisfies my OCD.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

diff --git a/.travis.yml b/.travis.yml
index 1d78421..0dbf2da 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,23 +14,23 @@ env:
     - GUI_PKGS="libgtk-3-dev libvte-2.90-dev libsdl1.2-dev libpng12-dev libpixman-1-dev"
     - EXTRA_PKGS=""
   matrix:
-  - TARGETS=alpha-softmmu,alpha-linux-user
-  - TARGETS=arm-softmmu,arm-linux-user
-  - TARGETS=aarch64-softmmu,aarch64-linux-user
-  - TARGETS=cris-softmmu
-  - TARGETS=i386-softmmu,x86_64-softmmu
-  - TARGETS=lm32-softmmu
-  - TARGETS=m68k-softmmu
-  - TARGETS=microblaze-softmmu,microblazeel-softmmu
-  - TARGETS=mips-softmmu,mips64-softmmu,mips64el-softmmu,mipsel-softmmu
-  - TARGETS=moxie-softmmu
-  - TARGETS=or32-softmmu,
-  - TARGETS=ppc-softmmu,ppc64-softmmu,ppcemb-softmmu
-  - TARGETS=s390x-softmmu
-  - TARGETS=sh4-softmmu,sh4eb-softmmu
-  - TARGETS=sparc-softmmu,sparc64-softmmu
-  - TARGETS=unicore32-softmmu
-  - TARGETS=xtensa-softmmu,xtensaeb-softmmu
+    - TARGETS=alpha-softmmu,alpha-linux-user
+    - TARGETS=arm-softmmu,arm-linux-user
+    - TARGETS=aarch64-softmmu,aarch64-linux-user
+    - TARGETS=cris-softmmu
+    - TARGETS=i386-softmmu,x86_64-softmmu
+    - TARGETS=lm32-softmmu
+    - TARGETS=m68k-softmmu
+    - TARGETS=microblaze-softmmu,microblazeel-softmmu
+    - TARGETS=mips-softmmu,mips64-softmmu,mips64el-softmmu,mipsel-softmmu
+    - TARGETS=moxie-softmmu
+    - TARGETS=or32-softmmu,
+    - TARGETS=ppc-softmmu,ppc64-softmmu,ppcemb-softmmu
+    - TARGETS=s390x-softmmu
+    - TARGETS=sh4-softmmu,sh4eb-softmmu
+    - TARGETS=sparc-softmmu,sparc64-softmmu
+    - TARGETS=unicore32-softmmu
+    - TARGETS=xtensa-softmmu,xtensaeb-softmmu
 before_install:
   - git submodule update --init --recursive
   - sudo apt-get update -qq
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH v1 4/4] .travis.yml: add IRC notifications for build failures
  2014-02-20 15:37 [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing alex.bennee
                   ` (2 preceding siblings ...)
  2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 3/4] .travis.yml: trivial whitespace fixup alex.bennee
@ 2014-02-20 15:37 ` alex.bennee
  2014-02-24 15:41 ` [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing Stefan Hajnoczi
  4 siblings, 0 replies; 6+ messages in thread
From: alex.bennee @ 2014-02-20 15:37 UTC (permalink / raw)
  To: qemu-devel

From: Alex Bennée <alex.bennee@linaro.org>

I'm trying to avoid spamming the IRC channel (not overly likely as
builds take a while). So failure will always be reported but if the
build continues to work then the IRC notifications will be quiet.

Note any GitHub based repository with Travis enabled will use this
notification. If it proves to be too spammy we may want to ask users not
to use Travis themselves although this seems sub-optimal.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

diff --git a/.travis.yml b/.travis.yml
index 0dbf2da..04da973 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,6 +4,12 @@ python:
 compiler:
   - gcc
   - clang
+notifications:
+  irc:
+    channels:
+      - "irc.oftc.net#qemu"
+    on_success: change
+    on_failure: always
 env:
   global:
     - TEST_CMD="make check"
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing
  2014-02-20 15:37 [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing alex.bennee
                   ` (3 preceding siblings ...)
  2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 4/4] .travis.yml: add IRC notifications for build failures alex.bennee
@ 2014-02-24 15:41 ` Stefan Hajnoczi
  4 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2014-02-24 15:41 UTC (permalink / raw)
  To: alex.bennee; +Cc: qemu-devel

On Thu, Feb 20, 2014 at 03:37:12PM +0000, alex.bennee@linaro.org wrote:
> From: Alex Bennée <alex.bennee@linaro.org>
> 
> Hi,
> 
> I've now enabled Travis testing on the "official" QEMU GitHub mirror.
> 
> Of the following patches two expand the testing, one is a cosmetic
> whitespace fix and the final one enabled IRC notification when the
> build fails. This is potentially controversial but on balance I think
> it would be worth while letting #qemu know as soon as master breaks.
> If lots of people start enabling Travis on there own repos then maybe
> we would reconsider the notification idea.
> 
> As it is build failures should automatically email the author of
> ${HEAD} as well as the owner of the repo.
> 
> There has been interest expressed in running tests on all PULL
> requests. One option would be to have some sort of bot (via
> patchwork?) push PULL request heads to another GitHub mirror
> (qemu-pull-requests.git?) to trigger builds.
> 
> 
> Alex Bennée (4):
>   .travis.yml: add a new build target with non-core devlibs
>   .travis.yml: re-enable lttng user space trace test
>   .travis.yml: trivial whitespace fixup
>   .travis.yml: add IRC notifications for build failures
> 
>  .travis.yml | 53 +++++++++++++++++++++++++++++++----------------------
>  1 file changed, 31 insertions(+), 22 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Regarding IRC spamming, I think this is okay for now.  If it becomes
more annoying than helpful (e.g. too many people pushing broken builds
onto GitHub) then we can always change .travis.yml.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-02-24 15:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-20 15:37 [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing alex.bennee
2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 1/4] .travis.yml: add a new build target with non-core devlibs alex.bennee
2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 2/4] .travis.yml: re-enable lttng user space trace test alex.bennee
2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 3/4] .travis.yml: trivial whitespace fixup alex.bennee
2014-02-20 15:37 ` [Qemu-devel] [PATCH v1 4/4] .travis.yml: add IRC notifications for build failures alex.bennee
2014-02-24 15:41 ` [Qemu-devel] [PATCH v1 0/4] Updates for Travis testing Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).