* [Qemu-devel] [PATCH] stubs: Optimize dependencies for gdbstub.c
@ 2014-02-20 19:08 Stefan Weil
2014-03-02 13:14 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2014-02-20 19:08 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel
It does not need qemu-common.h. Including exec/gdbstub.h fixes a warning
from static code analyzers and avoids mismatching declarations for
xml_builtin.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
stubs/gdbstub.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/stubs/gdbstub.c b/stubs/gdbstub.c
index c1dbfe7..f6a4553 100644
--- a/stubs/gdbstub.c
+++ b/stubs/gdbstub.c
@@ -1,4 +1,6 @@
-#include "qemu-common.h"
+#include "stdbool.h" /* bool (in exec/gdbstub.h) */
+#include "stddef.h" /* NULL */
+#include "exec/gdbstub.h" /* xml_builtin */
const char *const xml_builtin[][2] = {
{ NULL, NULL }
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] stubs: Optimize dependencies for gdbstub.c
2014-02-20 19:08 [Qemu-devel] [PATCH] stubs: Optimize dependencies for gdbstub.c Stefan Weil
@ 2014-03-02 13:14 ` Michael Tokarev
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2014-03-02 13:14 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
20.02.2014 23:08, Stefan Weil wrote:
> It does not need qemu-common.h. Including exec/gdbstub.h fixes a warning
> from static code analyzers and avoids mismatching declarations for
> xml_builtin.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-02 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-20 19:08 [Qemu-devel] [PATCH] stubs: Optimize dependencies for gdbstub.c Stefan Weil
2014-03-02 13:14 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).