From: Chunyan Liu <cyliu@suse.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>,
Chunyan Liu <cyliu@suse.com>,
stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v21 15/25] raw-win32.c: replace QEMUOptionParameter with QemuOpts
Date: Fri, 21 Feb 2014 18:35:38 +0800 [thread overview]
Message-ID: <1392978948-27416-16-git-send-email-cyliu@suse.com> (raw)
In-Reply-To: <1392978948-27416-1-git-send-email-cyliu@suse.com>
raw-win32.c: replace QEMUOptionParameter with QemuOpts
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
block/raw-win32.c | 34 +++++++++++++++++-----------------
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/block/raw-win32.c b/block/raw-win32.c
index ae1c8e6..d94973f 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -464,19 +464,14 @@ static int64_t raw_get_allocated_file_size(BlockDriverState *bs)
return st.st_size;
}
-static int raw_create(const char *filename, QEMUOptionParameter *options,
- Error **errp)
+static int raw_create(const char *filename, QemuOpts *opts, Error **errp)
{
int fd;
int64_t total_size = 0;
/* Read out options */
- while (options && options->name) {
- if (!strcmp(options->name, BLOCK_OPT_SIZE)) {
- total_size = options->value.n / 512;
- }
- options++;
- }
+ total_size =
+ qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0) / 512;
fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
0644);
@@ -490,13 +485,18 @@ static int raw_create(const char *filename, QEMUOptionParameter *options,
return 0;
}
-static QEMUOptionParameter raw_create_options[] = {
- {
- .name = BLOCK_OPT_SIZE,
- .type = OPT_SIZE,
- .help = "Virtual disk size"
- },
- { NULL }
+
+static QemuOptsList raw_create_opts = {
+ .name = "raw-create-opts",
+ .head = QTAILQ_HEAD_INITIALIZER(raw_create_opts.head),
+ .desc = {
+ {
+ .name = BLOCK_OPT_SIZE,
+ .type = QEMU_OPT_SIZE,
+ .help = "Virtual disk size"
+ },
+ { /* end of list */ }
+ }
};
static BlockDriver bdrv_file = {
@@ -506,7 +506,7 @@ static BlockDriver bdrv_file = {
.bdrv_needs_filename = true,
.bdrv_file_open = raw_open,
.bdrv_close = raw_close,
- .bdrv_create = raw_create,
+ .bdrv_create2 = raw_create,
.bdrv_has_zero_init = bdrv_has_zero_init_1,
.bdrv_aio_readv = raw_aio_readv,
@@ -518,7 +518,7 @@ static BlockDriver bdrv_file = {
.bdrv_get_allocated_file_size
= raw_get_allocated_file_size,
- .create_options = raw_create_options,
+ .create_opts = &raw_create_opts,
};
/***********************************************/
--
1.6.0.2
next prev parent reply other threads:[~2014-02-21 10:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 10:35 [Qemu-devel] [PATCH v21 00/25] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 01/25] add def_value_str to QemuOptDesc Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 02/25] qapi: output def_value_str when query command line options Chunyan Liu
2014-03-04 0:02 ` Eric Blake
2014-03-04 2:01 ` Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 03/25] improve some functions in qemu-option.c Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 04/25] improve assertion in qemu_opt_get functions Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 05/25] add some QemuOpts functions for replace work Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 06/25] add convert functions between QEMUOptionParameter to QemuOpts Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 07/25] change block layer to support both QemuOpts and QEMUOptionParamter Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 08/25] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 09/25] gluster.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 10/25] iscsi.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 11/25] qcow.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 12/25] qcow2.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 13/25] qed.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 14/25] raw-posix.c: " Chunyan Liu
2014-02-21 10:35 ` Chunyan Liu [this message]
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 16/25] raw_bsd.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 17/25] rbd.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 18/25] sheepdog.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 19/25] ssh.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 20/25] vdi.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 21/25] vmdk.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 22/25] vpc.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 23/25] vhdx.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 24/25] vvfat.c: " Chunyan Liu
2014-02-21 10:35 ` [Qemu-devel] [PATCH v21 25/25] cleanup QEMUOptionParameter Chunyan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392978948-27416-16-git-send-email-cyliu@suse.com \
--to=cyliu@suse.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).