From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGpLg-0000Xt-Ie for qemu-devel@nongnu.org; Fri, 21 Feb 2014 07:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGpLa-0005kq-IK for qemu-devel@nongnu.org; Fri, 21 Feb 2014 07:37:00 -0500 From: Markus Armbruster Date: Fri, 21 Feb 2014 13:36:49 +0100 Message-Id: <1392986209-32162-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] qga: Fix memory allocation pasto List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, mdroth@linux.vnet.ibm.com qmp_guest_file_seek() allocates memory for a GuestFileRead object instead of the GuestFileSeek object it actually uses. Harmless, because the GuestFileRead is slightly larger. Signed-off-by: Markus Armbruster --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index cae4171..2c496b6 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -525,7 +525,7 @@ struct GuestFileSeek *qmp_guest_file_seek(int64_t handle, int64_t offset, if (ret == -1) { error_setg_errno(err, errno, "failed to seek file"); } else { - seek_data = g_malloc0(sizeof(GuestFileRead)); + seek_data = g_new0(GuestFileSeek, 1); seek_data->position = ftell(fh); seek_data->eof = feof(fh); } -- 1.8.1.4