qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Benoît Canet" <benoit@irqsave.net>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/2] quorum: Simplify quorum_open()
Date: Fri, 21 Feb 2014 22:30:36 +0100	[thread overview]
Message-ID: <1393018238-15068-1-git-send-email-mreitz@redhat.com> (raw)

This series employs the new ability of qdict_array_split() to not only
split a QDict into a QList of QDicts (and a remainder QDict), but into a
QList of QObjects of any kind, to simplify quorum_open(). This (in my
opinion) enhances readability, robustness against malformatted options
and allows specifying both reference strings and full option dicts at
the same time.

This series depends on v19 of Benoît's Quorum series and on my "Extract
non-QDicts in qdict_array_split()" series.

v2:
 - Patch 1: Adapted comment about how num_children is determined
   [Benoît]
 - Patch 2: Fixing the monitor output of quorum (v19) requires fixing of
   the test output as well; however, filtering the sector-num is no
   longer required


Max Reitz (2):
  quorum: Simplify quorum_open()
  iotests: Mixed quorum child device specifications

 block/quorum.c             | 66 +++++++++++++++++++++++++++-------------------
 tests/qemu-iotests/081     | 51 +++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/081.out | 15 +++++++++++
 3 files changed, 105 insertions(+), 27 deletions(-)

-- 
1.9.0

             reply	other threads:[~2014-02-21 21:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 21:30 Max Reitz [this message]
2014-02-21 21:30 ` [Qemu-devel] [PATCH v2 1/2] quorum: Simplify quorum_open() Max Reitz
2014-02-21 21:30 ` [Qemu-devel] [PATCH v2 2/2] iotests: Mixed quorum child device specifications Max Reitz
2014-02-21 21:38   ` Benoît Canet
2014-02-21 21:40 ` [Qemu-devel] [PATCH v2 0/2] quorum: Simplify quorum_open() Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393018238-15068-1-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).