From: Xuebing Wang <xbing6@gmail.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, xbing6@gmail.com, stefanha@redhat.com,
alex@alex.org.uk
Subject: [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category
Date: Tue, 25 Feb 2014 21:36:47 +0800 [thread overview]
Message-ID: <1393335414-27589-1-git-send-email-xbing6@gmail.com> (raw)
There are 6 categories of APIs:
- QEMUClockType
- QEMUTimerList
- QEMUTimerListGroup
- QEMUTimer
- General utility functions
- Low level clock functions
Problems / solutions with previous API implementations:
1) Can not think of cases that we need QEMUTimerList APIs.
Reference: kernel_tree/Documentation/SubmittingPatches
-- Section "4) Don't over-design"
Purpose: simplify API
Solution: remove them from APIs
2) Implementations of some APIs are interwined
Purpose: put them together according to their categories, thus new
engineers are easy to understand them
Solution: put them together
3) Unnecessary header files are included
Purpose: simplify the included header files
Solution: only include the minimally required header file
This patchset includes below changes:
- put QEMUTimerList related functions together and make them private
- put QEMUClockType related functions together
- move QEMUTimerListGroup function to be below QEMUClockType
- put QEMUTimer related functions together
- put general utility functions together
- clean unnecessary #include and use minimal required #include
Xuebing Wang (7):
timer: move QEMUTimerList functions together
timer: make QEMUTimerList functions private (remove from APIs)
timer: move QEMUClockType related functions together
timer: move QEMUTimerListGroup function to be below QEMUClockType
timer: move QEMUTimer related functions together
timer: move general utility functions together
timer: clean unnecessary #include and use minimal required #include
include/qemu/timer.h | 94 --------
qemu-timer.c | 595 +++++++++++++++++++++++++++++---------------------
2 files changed, 341 insertions(+), 348 deletions(-)
--
1.7.9.5
next reply other threads:[~2014-02-25 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 13:36 Xuebing Wang [this message]
2014-02-25 13:36 ` [Qemu-devel] [PATCH 1/7] timer: move QEMUTimerList functions together Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 2/7] timer: make QEMUTimerList functions private (remove from APIs) Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 3/7] timer: move QEMUClockType related functions together Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 4/7] timer: move QEMUTimerListGroup function to be below QEMUClockType Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 5/7] timer: move QEMUTimer related functions together Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 6/7] timer: move general utility " Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 7/7] timer: clean unnecessary #include and use minimal required #include Xuebing Wang
2014-02-25 16:25 ` [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category Alex Bligh
2014-02-25 16:38 ` Paolo Bonzini
2014-02-27 21:52 ` Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393335414-27589-1-git-send-email-xbing6@gmail.com \
--to=xbing6@gmail.com \
--cc=alex@alex.org.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).