From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIICK-0003hI-Fn for qemu-devel@nongnu.org; Tue, 25 Feb 2014 08:37:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIICC-0004RM-3l for qemu-devel@nongnu.org; Tue, 25 Feb 2014 08:37:24 -0500 Received: from mail-pd0-x22a.google.com ([2607:f8b0:400e:c02::22a]:42621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIICB-0004RI-Sg for qemu-devel@nongnu.org; Tue, 25 Feb 2014 08:37:16 -0500 Received: by mail-pd0-f170.google.com with SMTP id y10so4558221pdj.15 for ; Tue, 25 Feb 2014 05:37:14 -0800 (PST) From: Xuebing Wang Date: Tue, 25 Feb 2014 21:36:47 +0800 Message-Id: <1393335414-27589-1-git-send-email-xbing6@gmail.com> Subject: [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, xbing6@gmail.com, stefanha@redhat.com, alex@alex.org.uk There are 6 categories of APIs: - QEMUClockType - QEMUTimerList - QEMUTimerListGroup - QEMUTimer - General utility functions - Low level clock functions Problems / solutions with previous API implementations: 1) Can not think of cases that we need QEMUTimerList APIs. Reference: kernel_tree/Documentation/SubmittingPatches -- Section "4) Don't over-design" Purpose: simplify API Solution: remove them from APIs 2) Implementations of some APIs are interwined Purpose: put them together according to their categories, thus new engineers are easy to understand them Solution: put them together 3) Unnecessary header files are included Purpose: simplify the included header files Solution: only include the minimally required header file This patchset includes below changes: - put QEMUTimerList related functions together and make them private - put QEMUClockType related functions together - move QEMUTimerListGroup function to be below QEMUClockType - put QEMUTimer related functions together - put general utility functions together - clean unnecessary #include and use minimal required #include Xuebing Wang (7): timer: move QEMUTimerList functions together timer: make QEMUTimerList functions private (remove from APIs) timer: move QEMUClockType related functions together timer: move QEMUTimerListGroup function to be below QEMUClockType timer: move QEMUTimer related functions together timer: move general utility functions together timer: clean unnecessary #include and use minimal required #include include/qemu/timer.h | 94 -------- qemu-timer.c | 595 +++++++++++++++++++++++++++++--------------------- 2 files changed, 341 insertions(+), 348 deletions(-) -- 1.7.9.5