qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category
@ 2014-02-25 13:36 Xuebing Wang
  2014-02-25 13:36 ` [Qemu-devel] [PATCH 1/7] timer: move QEMUTimerList functions together Xuebing Wang
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Xuebing Wang @ 2014-02-25 13:36 UTC (permalink / raw)
  To: qemu-devel; +Cc: pbonzini, xbing6, stefanha, alex

There are 6 categories of APIs:
- QEMUClockType
- QEMUTimerList
- QEMUTimerListGroup
- QEMUTimer
- General utility functions
- Low level clock functions

Problems / solutions with previous API implementations:
1) Can not think of cases that we need QEMUTimerList APIs.
   Reference:  kernel_tree/Documentation/SubmittingPatches
               -- Section "4) Don't over-design"
   Purpose:    simplify API
   Solution:   remove them from APIs
2) Implementations of some APIs are interwined
   Purpose:    put them together according to their categories, thus new
               engineers are easy to understand them
   Solution:   put them together
3) Unnecessary header files are included
   Purpose:    simplify the included header files
   Solution:   only include the minimally required header file

This patchset includes below changes:
- put QEMUTimerList related functions together and make them private
- put QEMUClockType related functions together
- move QEMUTimerListGroup function to be below QEMUClockType
- put QEMUTimer related functions together
- put general utility functions together
- clean unnecessary #include and use minimal required #include

Xuebing Wang (7):
  timer: move QEMUTimerList functions together
  timer: make QEMUTimerList functions private (remove from APIs)
  timer: move QEMUClockType related functions together
  timer: move QEMUTimerListGroup function to be below QEMUClockType
  timer: move QEMUTimer related functions together
  timer: move general utility functions together
  timer: clean unnecessary #include and use minimal required #include

 include/qemu/timer.h |   94 --------
 qemu-timer.c         |  595 +++++++++++++++++++++++++++++---------------------
 2 files changed, 341 insertions(+), 348 deletions(-)

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2014-02-27 21:52 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-25 13:36 [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 1/7] timer: move QEMUTimerList functions together Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 2/7] timer: make QEMUTimerList functions private (remove from APIs) Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 3/7] timer: move QEMUClockType related functions together Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 4/7] timer: move QEMUTimerListGroup function to be below QEMUClockType Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 5/7] timer: move QEMUTimer related functions together Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 6/7] timer: move general utility " Xuebing Wang
2014-02-25 13:36 ` [Qemu-devel] [PATCH 7/7] timer: clean unnecessary #include and use minimal required #include Xuebing Wang
2014-02-25 16:25 ` [Qemu-devel] [PATCH 0/7] timer: move APIs together according to their category Alex Bligh
2014-02-25 16:38   ` Paolo Bonzini
2014-02-27 21:52 ` Alex Bligh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).