From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36549)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1WIiwy-0003nk-5Y
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 13:11:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1WIiws-0002JI-2R
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 13:11:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:18083)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.williamson@redhat.com>) id 1WIiwr-0002J4-On
	for qemu-devel@nongnu.org; Wed, 26 Feb 2014 13:11:14 -0500
Message-ID: <1393438270.18087.3.camel@ul30vt.home>
From: Alex Williamson <alex.williamson@redhat.com>
Date: Wed, 26 Feb 2014 11:11:10 -0700
In-Reply-To: <1393372061-12493-1-git-send-email-bsd@redhat.com>
References: <1393372061-12493-1-git-send-email-bsd@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2 v4] vfio: blacklist loading of unstable
	roms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bandan Das <bsd@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>

On Tue, 2014-02-25 at 18:47 -0500, Bandan Das wrote:
> v4:
> 1. Short Description of the issue in comments, pointer
> to qemu bug tracker in 2/2
> 2. Remove unnecessary check on rom_bar in vfio_pci_size_rom 2/2
> 3. No changes to 1/2 - Andreas, I have retained your "Reviewed-by"
> since the code hasn't changed.
> 
> v3:
> 1. Change the "force" logic to depend on whether the user specified rombar,
> eliminate dependence on multiple values of rom_bar
> 2. Avoid printing the informational message if there's no rom
> 3. Minor changes to commit messages
> 
> v2:
> 1. Break up into two patches separating the infrastructural changes
> 2. Change vendor_id and device_id type to uint16_t
> 3. Rename struct for blacklisted devid and vendorid to more meaningful names
> 4. Remove unnecessary rom_quirk variable and just call vfio_blacklist_opt_rom()
> in vfio_pci_size_rom()
> 
> Bandan Das (2):
>   qdev-monitor: set DeviceState opts before calling realize
>   vfio: blacklist loading of unstable roms
> 
>  hw/misc/vfio.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  qdev-monitor.c |  4 +++-
>  2 files changed, 76 insertions(+), 1 deletion(-)
> 

Applied, thanks!