From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ1cB-0008Mm-N0 for qemu-devel@nongnu.org; Thu, 27 Feb 2014 09:07:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ1c5-0001Sq-Oa for qemu-devel@nongnu.org; Thu, 27 Feb 2014 09:07:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ1c5-0001S9-G8 for qemu-devel@nongnu.org; Thu, 27 Feb 2014 09:07:01 -0500 Message-ID: <1393510015.27462.19.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 27 Feb 2014 15:06:55 +0100 In-Reply-To: References: <1393242771-28076-1-git-send-email-kraxel@redhat.com> <1393507157.27462.16.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v2 00/44] rework input handling, sdl2 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers Hi, > If you need to fix up somebody else's patch because they've > dumped it on the list and run away without fixing review > issues, the right way to do this is: > * retain their email as the author > * retain their Signed-off-by line > * after that, include a brief summary in square brackets > of the changes you made to it to fix it up, eg > [Gerd: fixed style issues, removed unnecessary code, fixed > breaking of baum2 code] (feel free to be more verbose) > * then add your Signed-off-by line underneath it Ok, I'll squash all SDL2 bits this way into a single patch then, which should resolve all issues. cheers, Gerd