From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ9LV-00010q-QF for qemu-devel@nongnu.org; Thu, 27 Feb 2014 17:22:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJ9LQ-0006Ty-25 for qemu-devel@nongnu.org; Thu, 27 Feb 2014 17:22:25 -0500 Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:64432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJ9LP-0006Tj-Sv for qemu-devel@nongnu.org; Thu, 27 Feb 2014 17:22:19 -0500 Received: by mail-qc0-f180.google.com with SMTP id i17so4101278qcy.39 for ; Thu, 27 Feb 2014 14:22:19 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 27 Feb 2014 23:22:08 +0100 Message-Id: <1393539728-27389-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] build: build block-obj-y explicitly before recursing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org block-obj-y is not anymore part of common-obj-y, because "nesting" variables is complicated and requires specifying the correct ordering in the calls to unnest-vars. However, because of this we need to specify block-obj-y in the dependencies of the target subdirectories. Thanks to Stefan Weil and Jeff Cody for suggesting the cause of the regression. Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index a443cd4..3938b6c 100644 --- a/Makefile +++ b/Makefile @@ -167,7 +167,7 @@ subdir-dtc:dtc/libfdt dtc/tests dtc/%: mkdir -p $@ -$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) +$(SUBDIR_RULES): libqemuutil.a libqemustub.a $(common-obj-y) $(block-obj-y) ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS)) romsubdir-%: -- 1.8.5.3