qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PULL 22/38] input: mouse: switch spice ui to new core
Date: Fri, 28 Feb 2014 15:06:33 +0100	[thread overview]
Message-ID: <1393596409-28934-23-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1393596409-28934-1-git-send-email-kraxel@redhat.com>

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/spice-input.c | 62 ++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 38 insertions(+), 24 deletions(-)

diff --git a/ui/spice-input.c b/ui/spice-input.c
index c9df699..6dab23b 100644
--- a/ui/spice-input.c
+++ b/ui/spice-input.c
@@ -98,41 +98,52 @@ static void kbd_leds(void *opaque, int ledstate)
 typedef struct QemuSpicePointer {
     SpiceMouseInstance  mouse;
     SpiceTabletInstance tablet;
-    int width, height, x, y;
+    int width, height;
+    uint32_t last_bmask;
     Notifier mouse_mode;
     bool absolute;
 } QemuSpicePointer;
 
-static int map_buttons(int spice_buttons)
+static void spice_update_buttons(QemuSpicePointer *pointer,
+                                 int wheel, uint32_t button_mask)
 {
-    int qemu_buttons = 0;
-
-    /*
-     * Note: SPICE_MOUSE_BUTTON_* specifies the wire protocol but this
-     * isn't what we get passed in via interface callbacks for the
-     * middle and right button ...
-     */
-    if (spice_buttons & SPICE_MOUSE_BUTTON_MASK_LEFT) {
-        qemu_buttons |= MOUSE_EVENT_LBUTTON;
+    static uint32_t bmap[INPUT_BUTTON_MAX] = {
+        [INPUT_BUTTON_LEFT]        = 0x01,
+        [INPUT_BUTTON_MIDDLE]      = 0x04,
+        [INPUT_BUTTON_RIGHT]       = 0x02,
+        [INPUT_BUTTON_WHEEL_UP]    = 0x10,
+        [INPUT_BUTTON_WHEEL_DOWN]  = 0x20,
+    };
+
+    if (wheel < 0) {
+        button_mask |= 0x10;
     }
-    if (spice_buttons & 0x04 /* SPICE_MOUSE_BUTTON_MASK_MIDDLE */) {
-        qemu_buttons |= MOUSE_EVENT_MBUTTON;
+    if (wheel > 0) {
+        button_mask |= 0x20;
     }
-    if (spice_buttons & 0x02 /* SPICE_MOUSE_BUTTON_MASK_RIGHT */) {
-        qemu_buttons |= MOUSE_EVENT_RBUTTON;
+
+    if (pointer->last_bmask == button_mask) {
+        return;
     }
-    return qemu_buttons;
+    qemu_input_update_buttons(NULL, bmap, pointer->last_bmask, button_mask);
+    pointer->last_bmask = button_mask;
 }
 
 static void mouse_motion(SpiceMouseInstance *sin, int dx, int dy, int dz,
                          uint32_t buttons_state)
 {
-    kbd_mouse_event(dx, dy, dz, map_buttons(buttons_state));
+    QemuSpicePointer *pointer = container_of(sin, QemuSpicePointer, mouse);
+    spice_update_buttons(pointer, dz, buttons_state);
+    qemu_input_queue_rel(NULL, INPUT_AXIS_X, dx);
+    qemu_input_queue_rel(NULL, INPUT_AXIS_Y, dy);
+    qemu_input_event_sync();
 }
 
 static void mouse_buttons(SpiceMouseInstance *sin, uint32_t buttons_state)
 {
-    kbd_mouse_event(0, 0, 0, map_buttons(buttons_state));
+    QemuSpicePointer *pointer = container_of(sin, QemuSpicePointer, mouse);
+    spice_update_buttons(pointer, 0, buttons_state);
+    qemu_input_event_sync();
 }
 
 static const SpiceMouseInterface mouse_interface = {
@@ -163,9 +174,10 @@ static void tablet_position(SpiceTabletInstance* sin, int x, int y,
 {
     QemuSpicePointer *pointer = container_of(sin, QemuSpicePointer, tablet);
 
-    pointer->x = x * 0x7FFF / (pointer->width - 1);
-    pointer->y = y * 0x7FFF / (pointer->height - 1);
-    kbd_mouse_event(pointer->x, pointer->y, 0, map_buttons(buttons_state));
+    spice_update_buttons(pointer, 0, buttons_state);
+    qemu_input_queue_abs(NULL, INPUT_AXIS_X, x, pointer->width);
+    qemu_input_queue_abs(NULL, INPUT_AXIS_Y, y, pointer->width);
+    qemu_input_event_sync();
 }
 
 
@@ -174,7 +186,8 @@ static void tablet_wheel(SpiceTabletInstance* sin, int wheel,
 {
     QemuSpicePointer *pointer = container_of(sin, QemuSpicePointer, tablet);
 
-    kbd_mouse_event(pointer->x, pointer->y, wheel, map_buttons(buttons_state));
+    spice_update_buttons(pointer, wheel, buttons_state);
+    qemu_input_event_sync();
 }
 
 static void tablet_buttons(SpiceTabletInstance *sin,
@@ -182,7 +195,8 @@ static void tablet_buttons(SpiceTabletInstance *sin,
 {
     QemuSpicePointer *pointer = container_of(sin, QemuSpicePointer, tablet);
 
-    kbd_mouse_event(pointer->x, pointer->y, 0, map_buttons(buttons_state));
+    spice_update_buttons(pointer, 0, buttons_state);
+    qemu_input_event_sync();
 }
 
 static const SpiceTabletInterface tablet_interface = {
@@ -199,7 +213,7 @@ static const SpiceTabletInterface tablet_interface = {
 static void mouse_mode_notifier(Notifier *notifier, void *data)
 {
     QemuSpicePointer *pointer = container_of(notifier, QemuSpicePointer, mouse_mode);
-    bool is_absolute  = kbd_mouse_is_absolute();
+    bool is_absolute  = qemu_input_is_absolute();
 
     if (pointer->absolute == is_absolute) {
         return;
-- 
1.8.3.1

  parent reply	other threads:[~2014-02-28 14:08 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 14:06 [Qemu-devel] [PULL v3 00/38] rework input handling, sdl2 support Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 01/38] console: export QemuConsole index, width, height Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 02/38] input: rename file to legacy Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 03/38] input: qapi: define event types Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 04/38] input: qapi: add unmapped key Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 05/38] input: qapi: add pause key Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 06/38] input: add core bits of the new input layer Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 07/38] input: keyboard: add helper functions to core Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 08/38] input: keyboard: switch legacy handlers to new core Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 09/38] input: keyboard: switch qmp_send_key() " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 10/38] input: keyboard: switch gtk ui " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 11/38] input: keyboard: switch sdl " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 12/38] input: keyboard: switch vnc " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 13/38] input: keyboard: switch spice " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 14/38] input: keyboard: switch curses " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 15/38] input: mouse: add helpers functions to core Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 16/38] input: mouse: add graphic_rotate support Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 17/38] input: mouse: add qemu_input_is_absolute() Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 18/38] input: mouse: switch legacy handlers to new core Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 19/38] input: mouse: switch gtk ui " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 20/38] input: mouse: switch sdl " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 21/38] input: mouse: switch vnc " Gerd Hoffmann
2014-02-28 14:06 ` Gerd Hoffmann [this message]
2014-02-28 14:06 ` [Qemu-devel] [PULL 23/38] input: mouse: switch monitor " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 24/38] input: keyboard: switch cocoa ui " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 25/38] input: mouse: " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 26/38] input: trace events Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 27/38] input-legacy: remove kbd_put_keycode Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 28/38] input-legacy: remove kbd_mouse_has_absolute Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 29/38] input-legacy: remove kbd_mouse_is_absolute Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 30/38] input-legacy: remove kbd_mouse_event Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 31/38] input: move mouse mode notifier to new core Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 32/38] input: add input_mouse_mode tracepoint Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 33/38] input: move qmp_query_mice to new core Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 34/38] input: move do_mouse_set " Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 35/38] input: remove index_from_keycode (no users) Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 36/38] console: add head to index to qemu consoles Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 37/38] console: add QemuUIInfo Gerd Hoffmann
2014-02-28 14:06 ` [Qemu-devel] [PULL 38/38] ui/sdl2 : initial port to SDL 2.0 (v2.0) Gerd Hoffmann
2014-03-04 15:54 ` [Qemu-devel] [PULL v3 00/38] rework input handling, sdl2 support Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393596409-28934-23-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).