From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJR1H-0003No-7W for qemu-devel@nongnu.org; Fri, 28 Feb 2014 12:14:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJR1C-0002Cn-OW for qemu-devel@nongnu.org; Fri, 28 Feb 2014 12:14:43 -0500 Sender: Richard Henderson From: Richard Henderson Date: Fri, 28 Feb 2014 09:14:29 -0800 Message-Id: <1393607671-23305-2-git-send-email-rth@twiddle.net> In-Reply-To: <1393607671-23305-1-git-send-email-rth@twiddle.net> References: <1393607671-23305-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PULL 1/3] target-i386: Fix CC_OP_CLR vs PF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org Parity should be set for a zero result. Cc: qemu-stable@nongnu.org Reviewed-by: Paolo Bonzini Reviewed-by: Edgar E. Iglesias Signed-off-by: Richard Henderson --- target-i386/cc_helper.c | 2 +- target-i386/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/cc_helper.c b/target-i386/cc_helper.c index ee04092..05dd12b 100644 --- a/target-i386/cc_helper.c +++ b/target-i386/cc_helper.c @@ -103,7 +103,7 @@ target_ulong helper_cc_compute_all(target_ulong dst, target_ulong src1, case CC_OP_EFLAGS: return src1; case CC_OP_CLR: - return CC_Z; + return CC_Z | CC_P; case CC_OP_MULB: return compute_all_mulb(dst, src1); diff --git a/target-i386/translate.c b/target-i386/translate.c index 5dd2450..aa985fa 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -748,7 +748,7 @@ static void gen_compute_eflags(DisasContext *s) return; } if (s->cc_op == CC_OP_CLR) { - tcg_gen_movi_tl(cpu_cc_src, CC_Z); + tcg_gen_movi_tl(cpu_cc_src, CC_Z | CC_P); set_cc_op(s, CC_OP_EFLAGS); return; } -- 1.8.5.3